Skip to content

Parse Spigot's primitive parameters correctly  #89

@PaulBGD

Description

@PaulBGD

You can see two issues with it in the AxisAlignedBB.grow method:

AxisAlignedBB      grow(DD;) (obf c) maybe wrong, return dont match        |        setMinZ(double)

It incorrectly matches it with setMinZ, because it doesn't parse the parameters for grow correctly. Not only does it cut off the last D (because the signature is double, double, double) but it doesn't parse the primitive types at all because it's not split by a ;.

I think in general the spigot parser could be a bit cleaner, there's a lot of presumptions in the parsing code.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions