Fix SetHamItemInfo string memory handlingFix SetHamItemInfo to store strings in the engine's string pool rather than keeping raw pointers from native parameters. Raw pointers could be overwritten, leading to crashes or undefined behavior.

Native is currently useless without this fix. Applied from upstream repo: alliedmodders#1128

Author: MisterCalvin

modules/hamsandwich/DataHandler.cpp

@@ -408,6 +408,7 @@ static cell AMX_NATIVE_CALL SetHamItemInfo(AMX *amx, cell *params)
 	ItemInfo *pItem = reinterpret_cast<ItemInfo *>(params[1]);
 	cell *ptr = MF_GetAmxAddr(amx, params[3]);
 	int iLen;
+	char *szString;
 
 	switch (params[2])
 	{
@@ -420,23 +421,26 @@ static cell AMX_NATIVE_CALL SetHamItemInfo(AMX *amx, cell *params)
 			break;
 
 		case ItemInfo_pszAmmo1:
-			pItem->pszAmmo1 = MF_GetAmxString(amx, params[3], 0, &iLen);
+			szString = MF_GetAmxString(amx, params[3], 0, &iLen);
+			pItem->pszAmmo1 = szString ? STRING(ALLOC_STRING(szString)) : nullptr;
 			return iLen;
 
 		case ItemInfo_iMaxAmmo1:
 			pItem->iMaxAmmo1 = *ptr;
 			break;
 
 		case ItemInfo_pszAmmo2:
-			pItem->pszAmmo2 = MF_GetAmxString(amx, params[3], 0, &iLen);
+			szString = MF_GetAmxString(amx, params[3], 0, &iLen);
+			pItem->pszAmmo2 = szString ? STRING(ALLOC_STRING(szString)) : nullptr;
 			return iLen;
 
 		case ItemInfo_iMaxAmmo2:
 			pItem->iMaxAmmo2 = *ptr;
 			break;
 
 		case ItemInfo_pszName:
-			pItem->pszName = MF_GetAmxString(amx, params[3], 0, &iLen);
+			szString = MF_GetAmxString(amx, params[3], 0, &iLen);
+			pItem->pszName = szString ? STRING(ALLOC_STRING(szString)) : nullptr;
 			return iLen;
 
 		case ItemInfo_iMaxClip: