Skip to content

Conversation

@xincjin-NOAA
Copy link

@xincjin-NOAA xincjin-NOAA commented Aug 1, 2025

This is an example .j2 file (for AMSU-A N19) used to create the observation engine dynamically (Ref: NOAA-EMC/spoc#58)

Related JCB work: NOAA-EMC/jcb#24

@xincjin-NOAA xincjin-NOAA requested a review from rmclaren August 6, 2025 18:10
Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I don't want to merge yet for fear of this breaking something in a cycled workflow, which we need to test next

atmosphere_obsdatain_script_path: DATA/obs
atmosphere_obsdatain_prefix: OPREFIX
atmosphere_obsdatain_suffix: ".2024020100.nc"
atmosphere_obsdatain_suffix_bufr : ".2024020100.bufr_d"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These will need to be added to the jcb-base YAMLs in GDASApp

CoryMartin-NOAA added a commit to NOAA-EMC/GDASApp that referenced this pull request Aug 11, 2025
# Description

<!-- Enter PR description here. -->
We need to set two variables in jcb-base.yaml.j2:

- atmosphere_obsdatain_script_path
- atmosphere_obsdatain_suffix_bufr

These are required to enable the get_obs_engine functionality in JCB.
Relevant background information can be found in the associated pull
requests listed below.

# Companion PRs

<!-- Enter links to any companion PRs here. -->
NOAA-EMC/spoc#58
NOAA-EMC/jcb-gdas#155
NOAA-EMC/jcb#26

# Issues

<!-- Enter any issues referenced or resolved by this PR here. Use
keywords "Resolves" or "Refs".
Resolves #1234
Refs #4321
Refs NOAA-EMC/repo#5678
-->

# Automated CI tests to run in Global Workflow
<!-- Which Global Workflow CI tests are required to adequately test this
PR? -->
- [ ] atm_jjob <!-- JEDI atm single cycle DA !-->
- [ ] C96C48_ufs_hybatmDA <!-- JEDI atm cycled DA !-->
- [ ] C96C48_hybatmsnowDA <!-- JEDI snow cycled DA !-->
- [ ] C96_gcafs_cycled <!-- JEDI aerosol cycled DA !-->
- [ ] C48mx500_3DVarAOWCDA <!-- JEDI low-res marine 3DVar cycled DA !-->
- [ ] C48mx500_hybAOWCDA <!-- JEDI marine hybrid envar cycled DA !-->
- [ ] C96C48_hybatmDA <!-- GSI atm cycled DA !-->

---------

Co-authored-by: Cory Martin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants