Skip to content

Commit 8788029

Browse files
authored
Merge pull request #87 from NeuroML/development
Test on windows-2019 See NeuroML/NeuroML2#185
2 parents 99002b9 + 0923e82 commit 8788029

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

.github/workflows/ci.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
fail-fast: false
1818
matrix:
1919
java: [ '8', '11', '16', '17' ]
20-
runs-on: [ubuntu-latest, macos-11, windows-latest ]
20+
runs-on: [ubuntu-latest, macos-11, windows-2019 ]
2121

2222
name: Test on Java ${{ matrix.Java }} on ${{ matrix.runs-on }}
2323
steps:
@@ -29,7 +29,7 @@ jobs:
2929
distribution: 'adopt'
3030

3131
- name: Install using getNeuroML.py (non Win)
32-
if: ${{ matrix.runs-on != 'windows-latest' }}
32+
if: ${{ matrix.runs-on != 'windows-2019' }}
3333
run: |
3434
export main_repo_branch=${{env.main_repo_branch}}
3535
if [[ ${main_repo_branch} != "master" && ${main_repo_branch} != "development" && ${main_repo_branch} != "experimental" && ${main_repo_branch} != *"osb"* ]]; then main_repo_branch=development ; fi
@@ -40,7 +40,7 @@ jobs:
4040
./jnml -v
4141
4242
- name: Install using getNeuroML.py (Win)
43-
if: ${{ matrix.runs-on == 'windows-latest' }}
43+
if: ${{ matrix.runs-on == 'windows-2019' }}
4444
run: |
4545
$env:main_repo_branch=$env:GITHUB_REF_NAME
4646
if ( $env:main_repo_branch -ne "master" -and $env:main_repo_branch -ne "development" -and $env:main_repo_branch -ne "experimental" -and $env:main_repo_branch -notlike '*osb*' ) { $env:main_repo_branch="development" }
@@ -52,7 +52,7 @@ jobs:
5252
.\jnml.bat -v
5353
5454
- name: Further tests (non Win)
55-
if: ${{ matrix.runs-on != 'windows-latest' }}
55+
if: ${{ matrix.runs-on != 'windows-2019' }}
5656
run: |
5757
pwd
5858
ls -alt
@@ -72,7 +72,7 @@ jobs:
7272
ls -alt ../NeuroML2/LEMSexamples
7373
7474
- name: Further tests (Win)
75-
if: ${{ matrix.runs-on == 'windows-latest' }}
75+
if: ${{ matrix.runs-on == 'windows-2019' }}
7676
run: |
7777
pwd
7878
mkdir results

pom.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,17 +32,17 @@
3232
<version>1.8.1</version>
3333
</dependency>
3434

35-
<!-- Dependencies to force use of log4j 2.15 -->
35+
<!-- Dependencies to force use of log4j 2.17.1 -->
3636
<dependency>
3737
<groupId>org.apache.logging.log4j</groupId>
3838
<artifactId>log4j-1.2-api</artifactId>
39-
<version>2.15.0</version>
39+
<version>2.17.1</version>
4040
<scope>test</scope>
4141
</dependency>
4242
<dependency>
4343
<groupId>org.apache.logging.log4j</groupId>
4444
<artifactId>log4j-slf4j-impl</artifactId>
45-
<version>2.15.0</version>
45+
<version>2.17.1</version>
4646
<scope>test</scope>
4747
</dependency>
4848

0 commit comments

Comments
 (0)