Skip to content

Commit cff37d3

Browse files
authored
Make waveform units configurable (#707)
1 parent db9e52a commit cff37d3

2 files changed

Lines changed: 8 additions & 6 deletions

File tree

core/nwb.misc.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -268,8 +268,8 @@ groups:
268268
required: false
269269
- name: unit
270270
dtype: text
271-
value: volts
272-
doc: Unit of measurement. This value is fixed to 'volts'.
271+
default_value: volts
272+
doc: Unit of measurement. The default value is 'volts'.
273273
required: false
274274
- name: waveform_sd
275275
neurodata_type_inc: VectorData
@@ -295,8 +295,8 @@ groups:
295295
required: false
296296
- name: unit
297297
dtype: text
298-
value: volts
299-
doc: Unit of measurement. This value is fixed to 'volts'.
298+
default_value: volts
299+
doc: Unit of measurement. The default value is 'volts'.
300300
required: false
301301
- name: waveforms
302302
neurodata_type_inc: VectorData
@@ -332,8 +332,8 @@ groups:
332332
required: false
333333
- name: unit
334334
dtype: text
335-
value: volts
336-
doc: Unit of measurement. This value is fixed to 'volts'.
335+
default_value: volts
336+
doc: Unit of measurement. The default value is 'volts'.
337337
required: false
338338
- name: waveforms_index
339339
neurodata_type_inc: VectorIndex

docs/format/source/format_release_notes.rst

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ Release Notes
88

99
Bug fixes
1010
^^^^^^^^^
11+
- ``Units.waveform_mean``, ``Units.waveform_sd``, and ``Units.waveforms`` now accept a unit other than the default
12+
value, ``volts``.
1113
- Fixed copy-paste error in ``VoltageClampSeries.capacitance_slow`` unit attribute doc, which incorrectly
1214
referenced ``capacitance_fast``.
1315
- Fixed ``IntervalSeries.data`` resolution and unit attribute docs, which were verbatim copy-paste from

0 commit comments

Comments
 (0)