Added Dell Precision 5570 #1535
Open
+85
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Jul 21, 2025
| VDPAU_DRIVER = lib.mkIf config.hardware.opengl.enable (lib.mkOverride 990 "nvidia"); | ||
| }; | ||
|
|
||
| hardware.enableRedistributableFirmware = lib.mkDefault true; |
There was a problem hiding this comment.
We already do this in the undetected profile in nixos-generate-config:
Suggested change
| hardware.enableRedistributableFirmware = lib.mkDefault true; |
Mic92
reviewed
Jul 21, 2025
| nvidiaBusId = "PCI:1:0:0"; | ||
| }; | ||
| }; | ||
| hardware.graphics.enable = lib.mkDefault true; |
There was a problem hiding this comment.
might be worth considering enabling this on all laptops, but than we should do this consistently and not in some modules only:
Suggested change
| hardware.graphics.enable = lib.mkDefault true; |
Mic92
reviewed
Jul 21, 2025
|
|
||
| hardware.enableRedistributableFirmware = lib.mkDefault true; | ||
| services.thermald.enable = lib.mkDefault true; | ||
| powerManagement.cpuFreqGovernor = lib.mkDefault "powersave"; |
There was a problem hiding this comment.
We no longer do set those in nixpkgs, so maybe we shouldn't set it in nixos-hardware either: NixOS/nixpkgs@fb602e5
Suggested change
| powerManagement.cpuFreqGovernor = lib.mkDefault "powersave"; |
Mic92
reviewed
Jul 21, 2025
Comment on lines
+21
to
+29
| boot.initrd.availableKernelModules = [ | ||
| "xhci_pci" | ||
| "thunderbolt" | ||
| "vmd" | ||
| "nvme" | ||
| "usb_storage" | ||
| "rtsx_pci_sdmmc" | ||
| ]; | ||
| boot.kernelModules = [ "kvm-intel" ]; |
There was a problem hiding this comment.
nixos-generate-config already generates those:
Suggested change
| boot.initrd.availableKernelModules = [ | |
| "xhci_pci" | |
| "thunderbolt" | |
| "vmd" | |
| "nvme" | |
| "usb_storage" | |
| "rtsx_pci_sdmmc" | |
| ]; | |
| boot.kernelModules = [ "kvm-intel" ]; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add support for Dell Precision 5570
Things done
nixos-hardwareandimporting it via
<nixos-hardware>or Flake input