Cataphract Skills #315
Draft
Cataphract Skills #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding all skills for Cataphract. These all need a mount to function.
|
Thanks for the PR. Since it essentially depends on #312, and that one is still a draft and will presumably require changes, I'm going to make this one a draft for the time being as well, to indicate that it's not ready to be merged just yet. I'd like to ask you to go over it again once we have companions merged, to make sure everything is still working, and afterwards we'll continue with the usual review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding all skills for Cataphract. These all need a mount to function.
There are two extra packets in Send.cs that I had implemented as a test a long time ago. I believe they are correct, but I can also remove them if they are undesired, this class doesn't need them (this is just the first time I've had to commit my Send.cs for a while).