Don't use init-only properties

Author: rhysparry

source/Halibut/Transport/Observability/SecureConnectionInfo.cs

@@ -18,7 +18,19 @@ namespace Halibut.Transport.Observability
 {
     public struct SecureConnectionInfo
     {
-        public SslProtocols SslProtocols { get; init; }
-        public ConnectionDirection ConnectionDirection { get; init; }
+        SecureConnectionInfo(
+            SslProtocols sslProtocols,
+            ConnectionDirection connectionDirection
+        )
+        {
+            SslProtocols = sslProtocols;
+            ConnectionDirection = connectionDirection;
+        }
+
+        public SslProtocols SslProtocols { get; }
+        public ConnectionDirection ConnectionDirection { get; }
+
+        public static SecureConnectionInfo CreateIncoming(SslProtocols sslProtocols) => new(sslProtocols, ConnectionDirection.Incoming);
+        public static SecureConnectionInfo CreateOutgoing(SslProtocols sslProtocols) => new(sslProtocols, ConnectionDirection.Outgoing);
     }
 }

source/Halibut/Transport/SecureListener.cs

@@ -340,13 +340,7 @@ await ssl
                     {
                         connectionAuthorizedAndObserved = true;
                         connectionsObserver.ConnectionAccepted(true);
-                        secureConnectionObserver.SecureConnectionEstablished(
-                            new SecureConnectionInfo
-                            {
-                                ConnectionDirection = ConnectionDirection.Incoming,
-                                SslProtocols = ssl.SslProtocol
-                            }
-                        );
+                        secureConnectionObserver.SecureConnectionEstablished(SecureConnectionInfo.CreateIncoming(ssl.SslProtocol));
                         tcpClientManager.AddActiveClient(thumbprint, client);
                         errorEventType = EventType.Error;
                         await ExchangeMessages(ssl).ConfigureAwait(false);

source/Halibut/Transport/TcpConnectionFactory.cs

@@ -68,13 +68,7 @@ await ssl.AuthenticateAsClientAsync(
             await ssl.FlushAsync(cancellationToken);
 
             log.Write(EventType.Security, "Secure connection established. Server at {0} identified by thumbprint: {1}, using protocol {2}", client.Client.RemoteEndPoint, serviceEndpoint.RemoteThumbprint, ssl.SslProtocol.ToString());
-            secureConnectionObserver.SecureConnectionEstablished(
-                new SecureConnectionInfo
-                {
-                    ConnectionDirection = ConnectionDirection.Outgoing,
-                    SslProtocols = ssl.SslProtocol
-                }
-            );
+            secureConnectionObserver.SecureConnectionEstablished(SecureConnectionInfo.CreateOutgoing(ssl.SslProtocol));
 
             return new SecureConnection(client, ssl, exchangeProtocolBuilder, halibutTimeoutsAndLimits, log);
         }