Include thumbrint in connection info

Author: rhysparry

source/Halibut/Transport/Observability/SecureConnectionInfo.cs

@@ -20,17 +20,33 @@ public struct SecureConnectionInfo
     {
         SecureConnectionInfo(
             SslProtocols sslProtocols,
-            ConnectionDirection connectionDirection
+            ConnectionDirection connectionDirection,
+            string thumbprint
         )
         {
             SslProtocols = sslProtocols;
             ConnectionDirection = connectionDirection;
+            Thumbprint = thumbprint;
         }
 
         public SslProtocols SslProtocols { get; }
         public ConnectionDirection ConnectionDirection { get; }
+        public string Thumbprint { get; }
 
-        public static SecureConnectionInfo CreateIncoming(SslProtocols sslProtocols) => new(sslProtocols, ConnectionDirection.Incoming);
-        public static SecureConnectionInfo CreateOutgoing(SslProtocols sslProtocols) => new(sslProtocols, ConnectionDirection.Outgoing);
+        public static SecureConnectionInfo CreateIncoming(
+            SslProtocols sslProtocols,
+            string thumbprint
+        )
+        {
+            return new SecureConnectionInfo(sslProtocols, ConnectionDirection.Incoming, thumbprint);
+        }
+
+        public static SecureConnectionInfo CreateOutgoing(
+            SslProtocols sslProtocols,
+            string thumbprint
+        )
+        {
+            return new(sslProtocols, ConnectionDirection.Outgoing, thumbprint);
+        }
     }
 }

source/Halibut/Transport/SecureListener.cs

@@ -340,7 +340,7 @@ await ssl
                     {
                         connectionAuthorizedAndObserved = true;
                         connectionsObserver.ConnectionAccepted(true);
-                        secureConnectionObserver.SecureConnectionEstablished(SecureConnectionInfo.CreateIncoming(ssl.SslProtocol));
+                        secureConnectionObserver.SecureConnectionEstablished(SecureConnectionInfo.CreateIncoming(ssl.SslProtocol, thumbprint));
                         tcpClientManager.AddActiveClient(thumbprint, client);
                         errorEventType = EventType.Error;
                         await ExchangeMessages(ssl).ConfigureAwait(false);

source/Halibut/Transport/TcpConnectionFactory.cs

@@ -68,7 +68,7 @@ await ssl.AuthenticateAsClientAsync(
             await ssl.FlushAsync(cancellationToken);
 
             log.Write(EventType.Security, "Secure connection established. Server at {0} identified by thumbprint: {1}, using protocol {2}", client.Client.RemoteEndPoint, serviceEndpoint.RemoteThumbprint, ssl.SslProtocol.ToString());
-            secureConnectionObserver.SecureConnectionEstablished(SecureConnectionInfo.CreateOutgoing(ssl.SslProtocol));
+            secureConnectionObserver.SecureConnectionEstablished(SecureConnectionInfo.CreateOutgoing(ssl.SslProtocol, serviceEndpoint.RemoteThumbprint ?? "Unknown"));
 
             return new SecureConnection(client, ssl, exchangeProtocolBuilder, halibutTimeoutsAndLimits, log);
         }