Fixed up the incorrect addition of a named package

Author: mcasperson

cmd/internal/converters/deployment_process_converter.go

@@ -118,30 +118,32 @@ func (c DeploymentProcessConverter) toHcl(resource octopus.DeploymentProcess, re
 					ExcludedEnvironments:          a.ExcludedEnvironments,
 					Channels:                      a.Channels,
 					TenantTags:                    a.TenantTags,
-					Package:                       make([]terraform.TerraformPackage, len(a.Packages)),
+					Package:                       []terraform.TerraformPackage{},
 					Condition:                     a.Condition,
 					RunOnServer:                   c.getRunOnServer(a.Properties),
 					Properties:                    nil,
 					Features:                      c.getFeatures(a.Properties),
 				}
 
-				for k, p := range a.Packages {
-					if strutil.EmptyIfNil(p.Name) != "" {
-						terraformResource.Step[i].Action[j].Package[k] = terraform.TerraformPackage{
-							Name:                    p.Name,
-							PackageID:               p.PackageId,
-							AcquisitionLocation:     p.AcquisitionLocation,
-							ExtractDuringDeployment: p.ExtractDuringDeployment,
-							FeedId:                  dependencies.GetResourcePointer("Feeds", p.FeedId),
-							Id:                      p.Id,
-							Properties:              c.replaceIds(p.Properties, dependencies),
-						}
+				for _, p := range a.Packages {
+					if strutil.NilIfEmptyPointer(p.Name) != nil {
+						terraformResource.Step[i].Action[j].Package = append(
+							terraformResource.Step[i].Action[j].Package,
+							terraform.TerraformPackage{
+								Name:                    p.Name,
+								PackageID:               p.PackageId,
+								AcquisitionLocation:     p.AcquisitionLocation,
+								ExtractDuringDeployment: &p.ExtractDuringDeployment,
+								FeedId:                  dependencies.GetResourcePointer("Feeds", p.FeedId),
+								Id:                      p.Id,
+								Properties:              c.replaceIds(p.Properties, dependencies),
+							})
 					} else {
 						terraformResource.Step[i].Action[j].PrimaryPackage = &terraform.TerraformPackage{
 							Name:                    nil,
 							PackageID:               p.PackageId,
 							AcquisitionLocation:     p.AcquisitionLocation,
-							ExtractDuringDeployment: p.ExtractDuringDeployment,
+							ExtractDuringDeployment: nil,
 							FeedId:                  dependencies.GetResourcePointer("Feeds", p.FeedId),
 							Id:                      p.Id,
 							Properties:              c.replaceIds(p.Properties, dependencies),

cmd/internal/model/terraform/terraform_deployment_process.go

@@ -48,7 +48,7 @@ type TerraformPackage struct {
 	Name                    *string           `hcl:"name"`
 	PackageID               *string           `hcl:"package_id"`
 	AcquisitionLocation     *string           `hcl:"acquisition_location"`
-	ExtractDuringDeployment bool              `hcl:"extract_during_deployment"`
+	ExtractDuringDeployment *bool             `hcl:"extract_during_deployment"`
 	FeedId                  *string           `hcl:"feed_id"`
 	Id                      *string           `hcl:"id"`
 	Properties              map[string]string `hcl:"properties"`