-
Notifications
You must be signed in to change notification settings - Fork 161
[frontend/backend] Remove expectation result empties in front #3661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3661 +/- ##
============================================
- Coverage 44.97% 44.89% -0.09%
- Complexity 2852 2860 +8
============================================
Files 771 772 +1
Lines 23486 23485 -1
Branches 1643 1651 +8
============================================
- Hits 10564 10543 -21
- Misses 12325 12343 +18
- Partials 597 599 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
83478cd
to
d5fd943
Compare
2d7dd00
to
63dee22
Compare
29da12b
to
77375aa
Compare
8e3cba8
to
439aa54
Compare
openbas-api/src/main/java/io/openbas/rest/exercise/service/ExerciseService.java
Outdated
Show resolved
Hide resolved
openbas-api/src/main/java/io/openbas/utils/mapper/ExerciseMapper.java
Outdated
Show resolved
Hide resolved
openbas-api/src/main/java/io/openbas/rest/atomic_testing/form/InjectResultOutput.java
Outdated
Show resolved
Hide resolved
openbas-api/src/main/java/io/openbas/rest/exercise/service/ExerciseService.java
Outdated
Show resolved
Hide resolved
openbas-api/src/main/java/io/openbas/rest/scenario/service/ScenarioStatisticService.java
Show resolved
Hide resolved
Everything seems to work as expected. |
@RomuDeuxfois I made the changes, ty! |
This reverts commit 44ce9f4.
Proposed changes
BackEnd
FrontEnd
Testing Instructions
Observations/comments:
** In the case where an inject has been executed and the expectations are met, and the user updates the inject content, the expectation result shown is the expectation related to the current execution (then this new type of expectation is not shown).
** Improvements: We should calculate the global score asynchronously as in ScenarioDistributionByExercise.
Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...