Skip to content

Conversation

camrrx
Copy link
Member

@camrrx camrrx commented Jul 23, 2025

Proposed changes

  • Posibility to create a role with a list of prdefined capabilities
  • Possibility to remove a role
  • Possibility to update a role
  • Possibility to assign role to user groups

Testing Instructions

  1. Go on security page -> Roles tabs
  2. Roles list with name, created date and updated date and following actions : update and delete
  3. Create role and check the capabilities list
  4. Go on groups tabs and "update roles"

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@camrrx camrrx force-pushed the issue/375_chunk_3-2 branch 2 times, most recently from bf9c6e1 to ecac9fa Compare July 23, 2025 13:13
@antoinemzs
Copy link
Member

@camrrx you should apply code formatting and linting and commit the changes

  • java: mvn spotless:apply
  • js/ts: yarn lint --fix

@heditar heditar added the filigran team use to identify PR from the Filigran team label Jul 25, 2025
@camrrx camrrx force-pushed the issue/375_chunk_3-2 branch from 4283101 to a8de12a Compare July 28, 2025 07:10
@camrrx camrrx force-pushed the issue/375_chunk_3-2 branch from a8de12a to 9246d5c Compare July 28, 2025 07:14
@heditar heditar self-requested a review July 28, 2025 12:33
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we removing it ?

Copy link

codecov bot commented Jul 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.67%. Comparing base (554f801) to head (92210ec).
⚠️ Report is 91 commits behind head on issue/375.

Additional details and impacted files
@@               Coverage Diff               @@
##             issue/375    #3695      +/-   ##
===============================================
+ Coverage        44.69%   45.67%   +0.97%     
- Complexity        2808     2890      +82     
===============================================
  Files              763      776      +13     
  Lines            23242    23467     +225     
  Branches          1627     1658      +31     
===============================================
+ Hits             10389    10718     +329     
+ Misses           12265    12149     -116     
- Partials           588      600      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@camrrx camrrx force-pushed the issue/375_chunk_3-2 branch 2 times, most recently from f2c5783 to 92210ec Compare July 29, 2025 14:46
@heditar heditar self-requested a review August 1, 2025 12:19
@camrrx camrrx merged commit 02eb0bb into issue/375 Aug 1, 2025
8 checks passed
@camrrx camrrx deleted the issue/375_chunk_3-2 branch August 1, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants