fix: update status bar item handling and add message for empty report files

Author: dermatz

CHANGELOG.md

@@ -1,15 +1,21 @@
-# Change Log
+# Changelog
 
 All notable changes to the "magento-log-viewer" extension will be documented in this file.
 
 Check [Keep a Changelog](http://keepachangelog.com/) for recommendations on how to structure this file.
 
 ## [Unreleased]
 
+## [1.7.1] - 2023-10-15
+
 ### Added
+- Added a message when there are no report files.
 - Support for Node.js 18.x in GitHub Actions
 - Automated tests for releases using GitHub Workflows
 
+### Fixed
+- Fixed an issue where the status bar item was being created multiple times.
+
 ## [1.7.0] - 2024-12-08
 
 ### Added

src/helpers.ts

@@ -151,9 +151,7 @@ export function updateBadge(treeView: vscode.TreeView<unknown>, logViewerProvide
     vscode.commands.executeCommand('setContext', 'magentoLogViewer.hasLogFiles', totalEntries > 0);
 
     // Update status bar item
-    const statusBarItem = vscode.window.createStatusBarItem(vscode.StatusBarAlignment.Left, 100);
-    statusBarItem.text = `Magento Log-Entries: ${totalEntries}`;
-    statusBarItem.show();
+    LogViewerProvider.statusBarItem.text = `Magento Log-Entries: ${totalEntries}`;
   };
 
   logViewerProvider.onDidChangeTreeData(updateBadgeCount);

src/logViewer.ts

@@ -6,13 +6,15 @@ import { pathExists, getLineCount, getIconForLogLevel, getLogItems, parseReportT
 export class LogViewerProvider implements vscode.TreeDataProvider<LogItem>, vscode.Disposable {
   private _onDidChangeTreeData: vscode.EventEmitter<LogItem | undefined | void> = new vscode.EventEmitter<LogItem | undefined | void>();
   readonly onDidChangeTreeData: vscode.Event<LogItem | undefined | void> = this._onDidChangeTreeData.event;
-  private statusBarItem: vscode.StatusBarItem;
+  public static statusBarItem: vscode.StatusBarItem;
   private groupByMessage: boolean;
 
   constructor(private workspaceRoot: string) {
-    this.statusBarItem = vscode.window.createStatusBarItem(vscode.StatusBarAlignment.Left, 100);
-    this.statusBarItem.command = 'magento-log-viewer.refreshLogFiles';
-    this.statusBarItem.show();
+    if (!LogViewerProvider.statusBarItem) {
+      LogViewerProvider.statusBarItem = vscode.window.createStatusBarItem(vscode.StatusBarAlignment.Left, 100);
+      LogViewerProvider.statusBarItem.command = 'magento-log-viewer.refreshLogFiles';
+      LogViewerProvider.statusBarItem.show();
+    }
     this.groupByMessage = vscode.workspace.getConfiguration('magentoLogViewer').get<boolean>('groupByMessage', true);
     this.updateBadge();
     this.updateRefreshButtonVisibility();
@@ -191,11 +193,11 @@ export class LogViewerProvider implements vscode.TreeDataProvider<LogItem>, vsco
     const logPath = path.join(this.workspaceRoot, 'var', 'log');
     const logFiles = this.getLogFilesWithoutUpdatingBadge(logPath);
     const totalEntries = logFiles.reduce((count, file) => count + parseInt(file.description?.match(/\d+/)?.[0] || '0', 10), 0);
-    this.statusBarItem.text = `Magento Log-Entries: ${totalEntries}`;
+    LogViewerProvider.statusBarItem.text = `Magento Log-Entries: ${totalEntries}`;
   }
 
   dispose() {
-    this.statusBarItem.dispose();
+    // Do not dispose the status bar item here to avoid multiple creations
   }
 }