Add RDM data to fixtures

[FloEdelmann]

We definitely don't want to duplicate everything from rdm.openlighting.org but we should be able to link to the respective page there and specify if a fixture supports RDM at all (also if there is no page in the RDM database). This includes at least the RDM model ID and the RDM personality ID.

See also #287

[peternewman]

Hi @FloEdelmann ,

To match your personality to an RDM personality, you'll need the RDM manufacturer ID, RDM device model ID and RDM personality number. You may also want to log the software version ID, as in theory a manufacturer could release an updated firmware which adds/changes the fields in a personality. I suspect realistically they'd just add a new personality rather than risking breaking backwards compatibility.

That would be enough to link to the model page (if it exists). It would also be enough to match your fixture profile in your system to a live device on the RDM bus.

[FloEdelmann]

@peternewman It's merged! You can have a look at it if you like.

Notable links:

• https://open-fixture-library.org/martin
• https://open-fixture-library.org/martin/mac-viper-wash
• https://open-fixture-library.org/rdm
• https://open-fixture-library.org/rdm?manufacturerId=21075&modelId=7
• changes in the fixture files

[peternewman]

Thanks!

I left a few comments on the PR (even though you've merged it).

I think there may be some clever stuff we can do with URLs to source the manufacturer info from our end, but I need to have a ponder and some free time...

[peternewman]

You're currently listing "RDM personality index: null" in a few places.

How about some anchors so we can jump to a particular RDM personality from the OLP RDM site on something like https://open-fixture-library.herokuapp.com/cameo/thunder-wash-600-rgb ?

[fxedel]

Thanks for filing this bug; #297 removes these null references.

Adding anchors sounds like a good idea, maybe we can also include it in #297

Linking to a manufacturer page works by omitting the modelId parameter:
https://open-fixture-library.org/rdm?manufacturerId=21075
We could add these links in OpenLightingProject/rdm-app#128

[peternewman]

Hi @fxedel ,

Thanks for sorting the nulls.

That sounds great in terms of the anchors. The other key thing that wants changing/extending is #291 (comment)

In terms of the manufacturer stuff, what I meant was we generate and use this:
https://github.com/OpenLightingProject/rdm-app/blob/master/data/manufacturer_data.py
By running this script:
https://github.com/OpenLightingProject/rdm-app/blob/master/tools/make_manufacturer_data.sh

If we also stored manufacturer URLs for RDM manufacturers on our side (which would benefit us too, as we could link to them not just their product URLs), then you could do a bulk import of the RDM manufacturer IDs, their official names in RDM terms and any URLs we've gathered.

[fxedel]

Ah, you meant the manufacturers' websites, didn't you? Good idea on sharing collected data! That's also related to importing from rdm.openlighting.org (#287).

[peternewman]

Yep. Your data for that is all in https://github.com/FloEdelmann/open-fixture-library/blob/master/fixtures/manufacturers.json isn't it?

We can then give you a list of every RDM capable manufacturer, along with their ID (and just allow your users to add manufacturers which can't do RDM. Although you may want to work out some mapping for short/pretty names and keys.

As I mentioned in #287 personally I'd actually be leaning towards using the RDM model collector direct from OLA and offering a translate/input option for that, rather than trying to send it through the RDM website (although we may be able to create some sort of basic bulk export for existing fixtures, but probably without the channel data etc for most of them, so it won't be much of a personality, just the personality name and how many channels.

[FloEdelmann]

Yes, all manufacturer-related data is in manufacturers.json.

Possibly, we could add a manufacturer property fullname, which is the same as the one registered at ESTA. I'd definitely like to keep the displayed names short and pretty and make the extended names optional. If we can do a bulk import of the manufacturer data, that prettifying can happen manually sometime afterwards.

I guess the existing RDM fixture data wouldn't add too much benefit if we imported them now, so we should rather focus on the RDM model collector import plugin, which could prefill more fields.