feat: fd-commands #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: leongross <[email protected]>
Signed-off-by: leongross <[email protected]>
Signed-off-by: leongross <[email protected]>
Signed-off-by: leongross <[email protected]>
Signed-off-by: leongross <[email protected]>
Signed-off-by: leongross <[email protected]>
The results for the corresponding pldm requests have an u8 field called CompletionCode. These completion codes are typically a set of PLDM_BASE_CODES and a selection of FW_UPDATE codes. To pass these return codes in a generic and type safe way, we want to define enums that implement the `From` trait for u8, individually for each response. Signed-off-by: leongross <[email protected]>
Signed-off-by: leongross <[email protected]>
Signed-off-by: leongross <[email protected]>
Signed-off-by: leongross <[email protected]>
Signed-off-by: leongross <[email protected]>
leongross
force-pushed
the
leongross/fd-commands
branch
from
9c282ea to
c32abc4
Compare
- QueryDownstreamIdentifiersResponse and Device parsing - fix test_request_firmware_data_response_codec Signed-off-by: leongross <[email protected]>
leongross
force-pushed
the
leongross/fd-commands
branch
from
de17b55 to
9123782
Compare
Collaborator
Author
|
Now that all tests pass, this is the current coverage: $ cargo tarpaulin
...
74.66% coverage, 1211/1622 lines covered, +6.87% change in coverage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.