Skip to content

Commit 5b5677f

Browse files
author
Ryan Louie
committed
Updating to make the @magenta/music 1.23.0 work
1 parent 49a0491 commit 5b5677f

File tree

5 files changed

+299
-63
lines changed

5 files changed

+299
-63
lines changed

configs/webpack/common.js

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -45,23 +45,6 @@ module.exports = {
4545
test: /\.tsx?$/,
4646
use: [
4747
{ loader: 'cache-loader' },
48-
{
49-
loader: 'thread-loader',
50-
options: {
51-
// there should be 1 cpu for the fork-ts-checker-webpack-plugin
52-
workers: require('os').cpus().length - 1,
53-
poolTimeout: Infinity, // set this to Infinity in watch mode - see https://github.com/webpack-contrib/thread-loader
54-
},
55-
},
56-
{
57-
loader: 'babel-loader',
58-
options: {
59-
cacheDirectory: true,
60-
babelrc: false,
61-
presets: ['@babel/preset-env', '@babel/preset-react'],
62-
plugins: ['react-hot-loader/babel'],
63-
},
64-
},
6548
{
6649
loader: 'ts-loader',
6750
options: {
@@ -89,21 +72,8 @@ module.exports = {
8972
],
9073
},
9174
plugins: [
92-
new ForkTsCheckerWebpackPlugin({
93-
checkSyntacticErrors: true,
94-
tsconfig: resolve(__dirname, '../../tsconfig.json'),
95-
exclude: '',
96-
}),
9775
new Dotenv(),
9876
new HtmlWebpackPlugin({ inject: true, template: 'index.html.ejs' }),
99-
new AutoDllPlugin({
100-
inject: true, // will inject the DLL bundles to index.html
101-
filename: dllFilename,
102-
entry: {
103-
vendor: vendorDependencies,
104-
},
105-
context: resolve(__dirname, '../../src'),
106-
}),
10777
],
10878
performance: {
10979
hints: false,

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
"webpack-merge": "^4.2.1"
4747
},
4848
"dependencies": {
49-
"@magenta/music": "1.9.0",
49+
"@magenta/music": "^1.23.1",
5050
"@material-ui/core": "^4.0.0",
5151
"@material-ui/icons": "^4.0.0",
5252
"@material-ui/lab": "^4.0.0-alpha.13",

src/core/player.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ class Player {
6464

6565
private player = new mm.SoundFontPlayer(
6666
SOUNDFONT_URL,
67-
Tone.master,
67+
Tone.Destination,
6868
undefined,
6969
undefined,
7070
this.playerCallbackObject

tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"sourceMap": true,
55
"noImplicitAny": false,
66
"module": "commonjs",
7-
"target": "es5",
7+
"target": "es6",
88
"jsx": "react",
99
"lib": ["es5", "es6", "dom"],
1010
"experimentalDecorators": true,

0 commit comments

Comments
 (0)