removed unnecessary NSM_HACKS functions and one other fun thing

Author: KaevonD

core/src/main/java/tc/oc/pgm/projectile/ProjectileModule.java

@@ -128,8 +128,8 @@ private static ProjectileDefinition.ProjectileEntity parseProjectileEntity(
       if (!entityText.matches("[a-zA-Z0-9_]+")) {
         throw new InvalidXMLException("Invalid entity type '" + entityText + "'", node);
       }
-      if (ABSTRACT_ENTITY_MAP.containsKey(entityText)) {
-        return ABSTRACT_ENTITY_MAP.get(entityText);
+      if (ABSTRACT_ENTITY_MAP.containsKey(entityText.toLowerCase())) {
+        return ABSTRACT_ENTITY_MAP.get(entityText.toLowerCase());
       }
       return new ProjectileDefinition.ProjectileEntity.RealEntity(XMLUtils.parseEntityTypeAttribute(element, attributeName, def));
     }

platform/platform-modern/src/main/java/tc/oc/pgm/platform/modern/impl/ModernNMSHacks.java

@@ -394,36 +394,4 @@ public int allocateEntityId() {
   public boolean isBlockDisplayEntity(Class<? extends Entity> entity) {
     return entity.isAssignableFrom(BlockDisplay.class);
   }
-
-  @Override
-  public void setTeleportationDuration(Entity entity, int duration) {
-    ((BlockDisplay) entity).setTeleportDuration(duration);
-  }
-
-  @Override
-  public void setBlockDisplayBlock(Entity entity, Material block) {
-    ((BlockDisplay) entity).setBlock(block.createBlockData());
-  }
-
-  @Override
-  public void alignBlockDisplayToPlayerFacing(Entity entity, float pitch, float yaw, float scale) {
-    final Matrix4f translation = new Matrix4f().translate(
-        new Vector3f(
-            -0.5f * scale,
-            -0.5f * scale,
-            -0.5f * scale
-        ));
-
-    final Matrix4f rotationMatrix = new Matrix4f();
-    final Quaternionf rotation = new Quaternionf();
-    rotation.rotateLocalX((float) Math.toRadians(-1 * pitch));
-    rotation.rotateLocalY((float) Math.toRadians(180 - yaw));
-    rotation.get(rotationMatrix);
-
-    final Matrix4f scaleMatrix = new Matrix4f().scale(scale);
-    final Matrix4f transformationMatrix = rotationMatrix.mul(translation.mul(scaleMatrix));
-    ((BlockDisplay) entity).setTransformationMatrix(
-        transformationMatrix
-    );
-  }
 }

platform/platform-sportpaper/src/main/java/tc/oc/pgm/platform/sportpaper/impl/SpNMSHacks.java

@@ -230,19 +230,4 @@ public int allocateEntityId() {
   public boolean isBlockDisplayEntity(Class<? extends Entity> entity) {
     return false;
   }
-
-  @Override
-  public void setTeleportationDuration(Entity entity, int duration) {
-    throw new UnsupportedOperationException("Teleportation duration is not supported on lower versions.");
-  }
-
-  @Override
-  public void setBlockDisplayBlock(Entity entity, Material block) {
-    throw new UnsupportedOperationException("Block display entities are not supported on lower versions.");
-  }
-
-  @Override
-  public void alignBlockDisplayToPlayerFacing(Entity entity, float pitch, float yaw, float scale) {
-    throw new UnsupportedOperationException("Block display entities are not supported on lower versions.");
-  }
 }

util/src/main/java/tc/oc/pgm/util/nms/NMSHacks.java

@@ -60,10 +60,4 @@ public interface NMSHacks {
   int allocateEntityId();
 
   boolean isBlockDisplayEntity(Class<? extends Entity> entity);
-
-  void setTeleportationDuration(Entity entity, int duration);
-
-  void setBlockDisplayBlock(Entity entity, Material block);
-
-  void alignBlockDisplayToPlayerFacing(Entity entity, float pitch, float yaw, float scale);
 }