[SQUASH-ME] Make sniff tests more realistic

Use the `(void)` cast correctly in the test code samples. `(void)` casts have to be used as a statement, not an expression.

Author: jrfnl

src/Standards/Generic/Tests/Formatting/SpaceAfterCastUnitTest.1.inc

@@ -99,6 +99,6 @@ $var = (boolean)/* comment */ $var2;
 $var = (  int )$spacesInsideParenthesis;
 $var = (	int		)$tabsInsideParenthesis;
 
-$var = (void) callMe();
-$var = (void)callMe();
-$var = (void)   callMe();
+(void) callMe();
+(void)callMe();
+(void)   callMe();

src/Standards/Generic/Tests/Formatting/SpaceAfterCastUnitTest.1.inc.fixed

@@ -96,6 +96,6 @@ $var = (boolean)/* comment */ $var2;
 $var = (  int ) $spacesInsideParenthesis;
 $var = (	int		) $tabsInsideParenthesis;
 
-$var = (void) callMe();
-$var = (void) callMe();
-$var = (void) callMe();
+(void) callMe();
+(void) callMe();
+(void) callMe();

src/Standards/Generic/Tests/Formatting/SpaceBeforeCastUnitTest.inc

@@ -64,6 +64,6 @@ $var = array(
 
 (bool) $a ? echo $b : echo $c;
 
-$var = (void) callMe();
-$var =(void) callMe();
-$var =   (void) callMe();
+(void) callMe();
+(void)(bool) callMe();
+   (void) callMe(); // Indentation whitespace before should be and will be ignored.

src/Standards/Generic/Tests/Formatting/SpaceBeforeCastUnitTest.inc.fixed

@@ -64,6 +64,6 @@ $var = array(
 
 (bool) $a ? echo $b : echo $c;
 
-$var = (void) callMe();
-$var = (void) callMe();
-$var = (void) callMe();
+(void) callMe();
+(void) (bool) callMe();
+   (void) callMe(); // Indentation whitespace before should be and will be ignored.

src/Standards/Generic/Tests/Formatting/SpaceBeforeCastUnitTest.php

@@ -62,7 +62,6 @@ public function getErrorList()
             55 => 1,
             56 => 1,
             68 => 1,
-            69 => 1,
         ];
     }
 

src/Standards/Generic/Tests/PHP/LowerCaseTypeUnitTest.1.inc

@@ -143,4 +143,4 @@ interface PHP84HookedProperty {
     public String $readable { get; }
 }
 
-$php85 = (VOID) callMe();
+(VOID) php85();

src/Standards/Generic/Tests/PHP/LowerCaseTypeUnitTest.1.inc.fixed

@@ -143,4 +143,4 @@ interface PHP84HookedProperty {
     public string $readable { get; }
 }
 
-$php85 = (void) callMe();
+(void) php85();

src/Standards/Squiz/Sniffs/Formatting/OperatorBracketSniff.php

@@ -304,6 +304,11 @@ public function addMissingBracketsError(File $phpcsFile, int $stackPtr)
         }
 
         $before = $phpcsFile->findNext(Tokens::EMPTY_TOKENS, ($before + 1), null, true);
+        if ($tokens[$before]['code'] === T_VOID_CAST) {
+            // Don't throw an error if a (void) cast is the first token in the expression
+            // as adding parentheses would turn that into a parse error.
+            return;
+        }
 
         // A few extra tokens are allowed to be on the right side of the expression.
         $allowed[T_EQUAL] = true;

src/Standards/Squiz/Tests/Formatting/OperatorBracketUnitTest.1.inc

@@ -206,4 +206,5 @@ $nsRelative = namespace\doSomething($items + 10);
 $partiallyQualified = Partially\qualified($items + 10);
 $fullyQualified = \Fully\qualified($items + 10);
 
-$php85voidcast = (void) CallMeOnce() + (void) CallMeTwice();
+// The below should be ignored as adding parentheses will turn this into a parse error.
+(void) CallMeOnce() + (bool) CallMeTwice();

src/Standards/Squiz/Tests/Formatting/OperatorBracketUnitTest.1.inc.fixed

@@ -206,4 +206,5 @@ $nsRelative = namespace\doSomething($items + 10);
 $partiallyQualified = Partially\qualified($items + 10);
 $fullyQualified = \Fully\qualified($items + 10);
 
-$php85voidcast = ((void) CallMeOnce() + (void) CallMeTwice());
+// The below should be ignored as adding parentheses will turn this into a parse error.
+(void) CallMeOnce() + (bool) CallMeTwice();