EndToEnd Tests: fix the code to allow for new exit codes

As of PHPCS 4.0, the exit codes have changed. This commit fixes the tests to expect the new exit codes.

Author: jrfnl

tests/EndToEnd/phpcbf_test.sh

@@ -20,7 +20,7 @@ function test_phpcbf_is_working_in_parallel() {
 
 function test_phpcbf_returns_error_on_issues() {
   OUTPUT="$( { bin/phpcbf --no-colors --no-cache --suffix=.fixed --standard=tests/EndToEnd/Fixtures/endtoend.xml.dist tests/EndToEnd/Fixtures/ClassWithStyleError.inc; } 2>&1 )"
-  assert_exit_code 1
+  assert_successful_code
 
   assert_contains "F 1 / 1 (100%)" "$OUTPUT"
   assert_contains "A TOTAL OF 1 ERROR WERE FIXED IN 1 FILE" "$OUTPUT"

tests/EndToEnd/phpcs_test.sh

@@ -10,7 +10,7 @@ function test_phpcs_is_working_in_parallel() {
 
 function test_phpcs_returns_error_on_issues() {
   OUTPUT="$( { bin/phpcs --no-colors --no-cache --standard=tests/EndToEnd/Fixtures/endtoend.xml.dist tests/EndToEnd/Fixtures/ClassWithStyleError.inc; } 2>&1 )"
-  assert_exit_code 2
+  assert_exit_code 1
 
   assert_contains "E 1 / 1 (100%)" "$OUTPUT"
   assert_contains "FOUND 1 ERROR AFFECTING 1 LINE" "$OUTPUT"