Merge pull request #650 from rodrigoprimo/test-coverage-interface-name-suffix

Generic/InterfaceNameSuffix: improve code coverage

Author: jrfnl

src/Standards/Generic/Sniffs/NamingConventions/InterfaceNameSuffixSniff.php

@@ -40,6 +40,7 @@ public function process(File $phpcsFile, $stackPtr)
     {
         $interfaceName = $phpcsFile->getDeclarationName($stackPtr);
         if ($interfaceName === null) {
+            // Live coding or parse error. Bow out.
             return;
         }
 

src/Standards/Generic/Tests/NamingConventions/InterfaceNameSuffixUnitTest.1.inc

@@ -0,0 +1,13 @@
+<?php
+
+interface SomeNameInterface {}
+
+interface MissingInterfaceSuffix {} // Error.
+
+interface CaseOfSuffixIsNotEnforced_interFACE {}
+
+interface
+    /*comment*/
+    InterfaceAnotherInvalidName
+    extends
+    AnotherInterface, \Countable {} // Error.

src/Standards/Generic/Tests/NamingConventions/InterfaceNameSuffixUnitTest.2.inc

@@ -0,0 +1,7 @@
+<?php
+
+// Intentional parse error (no interface name).
+// This should be the only test in this file.
+// Testing that the sniff is *not* triggered.
+
+interface

src/Standards/Generic/Tests/NamingConventions/InterfaceNameSuffixUnitTest.inc

@@ -25,11 +25,21 @@ final class InterfaceNameSuffixUnitTest extends AbstractSniffUnitTest
      * The key of the array should represent the line number and the value
      * should represent the number of errors that should occur on that line.
      *
+     * @param string $testFile The name of the test file.
+     *
      * @return array<int, int>
      */
-    public function getErrorList()
+    public function getErrorList($testFile='')
     {
-        return [8 => 1];
+        switch ($testFile) {
+        case 'InterfaceNameSuffixUnitTest.1.inc':
+            return [
+                5 => 1,
+                9 => 1,
+            ];
+        default:
+            return [];
+        }
 
     }//end getErrorList()