CS Complaining about not uisng $this->assertInternalType('object', $scanner);

MarkBaker · MarkBaker · commit 3abb7ccb357e · 2018-11-25T14:41:11.000+01:00
diff --git a/tests/PhpSpreadsheetTests/Reader/Security/XmlScannerTest.php b/tests/PhpSpreadsheetTests/Reader/Security/XmlScannerTest.php
@@ -63,7 +63,7 @@ public function testGetSecurityScannerForXmlBasedReader()
         $scanner = $fileReader->getSecuritySCanner();
 
         //    Must return an object...
-        $this->assertTrue(is_object($scanner));
+        $this->assertInternalType('object', $scanner);
         //    ... of the correct type
         $this->assertInstanceOf(XmlScanner::class, $scanner);
     }

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ public function testGetSecurityScannerForXmlBasedReader()`
`63`	`63`	`$scanner = $fileReader->getSecuritySCanner();`
`64`	`64`
`65`	`65`	`// Must return an object...`
`66`		`- $this->assertTrue(is_object($scanner));`
	`66`	`+ $this->assertInternalType('object', $scanner);`
`67`	`67`	`// ... of the correct type`
`68`	`68`	`$this->assertInstanceOf(XmlScanner::class, $scanner);`
`69`	`69`	`}`