WIP: Task: add EnumInstanceType::isUnspecified and make getMemberName throw if isUnspecified

Author: mhsdesign

src/TypeSystem/Resolver/Match/MatchTypeResolver.php

@@ -113,11 +113,11 @@ private function resolveTypeOfEnumMatch(MatchNode $matchNode, EnumInstanceType $
                         throw new \Error('@TODO Error: incompatible enum match: got ' . $enumMemberType->enumStaticType->enumName . ' expected ' . $subjectEnumType->enumStaticType->enumName);
                     }
 
-                    if (isset($referencedEnumMembers[$enumMemberType->memberName])) {
-                        throw new \Error('@TODO Error: Enum path ' . $enumMemberType->memberName . ' was already defined once in this match and cannot be used twice');
+                    if (isset($referencedEnumMembers[$enumMemberType->getMemberName()])) {
+                        throw new \Error('@TODO Error: Enum path ' . $enumMemberType->getMemberName() . ' was already defined once in this match and cannot be used twice');
                     }
 
-                    $referencedEnumMembers[$enumMemberType->memberName] = true;
+                    $referencedEnumMembers[$enumMemberType->getMemberName()] = true;
                 }
             }
 

src/TypeSystem/Type/EnumType/EnumInstanceType.php

@@ -28,29 +28,39 @@ final class EnumInstanceType implements TypeInterface
 {
     private function __construct(
         public readonly EnumStaticType $enumStaticType,
-        public readonly ?string $memberName
+        private readonly ?string $memberName
     ) {
         if ($memberName !== null && !$enumStaticType->hasMember($memberName)) {
-            throw new \Exception('@TODO cannot access member ' . $memberName . ' of enum ' . $this->enumStaticType->enumName);
+            throw new \Exception('@TODO cannot access member ' . $memberName . ' of enum ' . $enumStaticType->enumName);
         }
     }
 
-    public static function fromStaticEnumCreateUnspecificInstance(EnumStaticType $enumStaticType): self
+    public static function createUnspecifiedEnumInstanceType(EnumStaticType $enumStaticType): self
     {
         return new self(
             enumStaticType: $enumStaticType,
             memberName: null
         );
     }
 
-    public static function fromStaticEnumAndMemberName(EnumStaticType $enumStaticType, string $enumMemberName): self
+    public static function fromStaticEnumTypeAndMemberName(EnumStaticType $enumStaticType, string $enumMemberName): self
     {
         return new self(
             enumStaticType: $enumStaticType,
             memberName: $enumMemberName
         );
     }
 
+    public function isUnspecified(): bool
+    {
+        return $this->memberName === null;
+    }
+
+    public function getMemberName(): string
+    {
+        return $this->memberName ?? throw new \Exception('@TODO Error cannot access memberName of unspecified instance');
+    }
+
     public function is(TypeInterface $other): bool
     {
         if ($other === $this) {

src/TypeSystem/Type/EnumType/EnumStaticType.php

@@ -61,7 +61,7 @@ public function hasMember(string $memberName): bool
 
     public function getMemberType(string $memberName): EnumInstanceType
     {
-        return EnumInstanceType::fromStaticEnumAndMemberName(
+        return EnumInstanceType::fromStaticEnumTypeAndMemberName(
             $this,
             $memberName
         );
@@ -81,6 +81,6 @@ public function is(TypeInterface $other): bool
 
     public function toEnumInstanceType(): EnumInstanceType
     {
-        return EnumInstanceType::fromStaticEnumCreateUnspecificInstance($this);
+        return EnumInstanceType::createUnspecifiedEnumInstanceType($this);
     }
 }

test/Unit/TypeSystem/Resolver/Access/AccessTypeResolverTest.php

@@ -90,7 +90,7 @@ public function enumMemberAccessOnStaticEnum(): void
 
         $this->assertTrue($accessType->enumStaticType->is($someEnum));
 
-        $this->assertEquals("A", $accessType->memberName);
+        $this->assertEquals("A", $accessType->getMemberName());
     }
 
     /**

test/Unit/TypeSystem/Type/EnumType/EnumStaticTypeTest.php

@@ -95,7 +95,7 @@ public function providesMemberType(): void
         $this->assertInstanceOf(EnumInstanceType::class, $enumMemberType);
 
         $this->assertSame($enumStaticType, $enumMemberType->enumStaticType);
-        $this->assertSame('A', $enumMemberType->memberName);
+        $this->assertSame('A', $enumMemberType->getMemberName());
     }
 
     /**
@@ -135,7 +135,7 @@ public function canBeTransformedIntoInstanceType(): void
 
         $this->assertInstanceOf(EnumStaticType::class, $enumInstanceType->enumStaticType);
 
-        $this->assertNull($enumInstanceType->memberName);
+        $this->assertTrue($enumInstanceType->isUnspecified());
     }
 
     /**
@@ -152,6 +152,8 @@ public function canBeComparedToOther(): void
             $enumDeclarationNode
         );
 
+        $this->assertTrue($enumStaticType->is($enumStaticType));
+
         $enumStaticType2 = EnumStaticType::fromModuleIdAndDeclaration(
             ModuleId::fromString("module-a"),
             $enumDeclarationNode