chore: various improvements after review

Author: lmammino

09-behavioral-design-patterns/02-state-failsafe-socket/onlineState.js

@@ -9,18 +9,23 @@ export class OnlineState {
   }
 
   async _tryFlush() {
-    let success = true
-    while (this.failsafeSocket.queue.length > 0) {
-      const data = this.failsafeSocket.queue[0]
-      const flushed = await this._tryWrite(data)
-      if (flushed) {
-        this.failsafeSocket.queue.shift()
-      } else {
-        success = false
-        break
+    try {
+      let success = true
+      while (this.failsafeSocket.queue.length > 0) {
+        const data = this.failsafeSocket.queue[0]
+        const flushed = await this._tryWrite(data)
+        if (flushed) {
+          this.failsafeSocket.queue.shift()
+        } else {
+          success = false
+          break
+        }
       }
-    }
-    if (!success) {
+      if (!success) {
+        this.failsafeSocket.changeState('offline')
+      }
+    } catch (err) {
+      console.error('Error during flush', err.message)
       this.failsafeSocket.changeState('offline')
     }
   }

09-behavioral-design-patterns/12-async-generator-check-urls/checkUrls.js

@@ -6,7 +6,7 @@ export class CheckUrls {
   async *[Symbol.asyncIterator]() {
     for (const url of this.urls) {
       try {
-        const checkResult = await await fetch(url, {
+        const checkResult = await fetch(url, {
           method: 'HEAD',
           redirect: 'follow',
           signal: AbortSignal.timeout(5000), // 5 secs timeout

09-behavioral-design-patterns/14-async-iterator-utilities/checkUrls.js

@@ -6,7 +6,7 @@ export class CheckUrls {
   async *[Symbol.asyncIterator]() {
     for (const url of this.urls) {
       try {
-        const checkResult = await await fetch(url, {
+        const checkResult = await fetch(url, {
           method: 'HEAD',
           redirect: 'follow',
           signal: AbortSignal.timeout(5000), // 5 secs timeout

09-behavioral-design-patterns/16-command/createPostStatusCmd.js

@@ -13,7 +13,7 @@ export function createPostStatusCmd(service, status) {
       }
     },
     serialize() {
-      return { type: 'status', action: 'post', status: status }
+      return { type: 'status', action: 'post', status }
     },
   }
 }