Handle task with error in callback instead of after await

Author: vdsabev

USERGUIDE

@@ -22,7 +22,7 @@ We're looking into adding such capabilities to Image Downloader in the future. I
 
 📝 Change Log
 ━━━━━━━
-3.3.1:
+3.3.2:
 - Disable slider handles when the checkbox is unchecked
 - Add tooltips to slider handles, slider checkboxes, and the Download button
 - Fix some issues with downloads not being cleaned up

manifest.json

@@ -1,7 +1,7 @@
 {
   "name": "Image Downloader",
   "description": "Browse and download images on the web",
-  "version": "3.3.1",
+  "version": "3.3.2",
   "minimum_chrome_version": "72",
   "manifest_version": 2,
   "icons": {

package-lock.json

@@ -1,7 +1,7 @@
 {
   "private": true,
   "name": "image-downloader",
-  "version": "3.3.1",
+  "version": "3.3.2",
   "license": "MIT",
   "scripts": {
     "start": "npm run build && node scripts/watch.js",

package.json

@@ -36,12 +36,16 @@ async function downloadImages(/** @type {Task} */ task) {
   tasks.add(task);
   for (const image of task.imagesToDownload) {
     await new Promise((resolve) => {
-      chrome.downloads.download({ url: image }, resolve);
+      chrome.downloads.download({ url: image }, (downloadId) => {
+        if (downloadId == null) {
+          if (chrome.runtime.lastError) {
+            console.error(`${image}:`, chrome.runtime.lastError.message);
+          }
+          task.next();
+        }
+        resolve();
+      });
     });
-    if (chrome.runtime.lastError) {
-      console.error(`${chrome.runtime.lastError.message}: ${image}`);
-    }
-    task.next();
   }
 }
 
@@ -72,6 +76,7 @@ function suggestNewFilename(item, suggest) {
   }
 
   suggest({ filename: normalizeSlashes(newFilename) });
+  task.next();
 }
 
 function normalizeSlashes(filename) {