Update SDA Downscaling to allow sf

CHANGELOG.md

@@ -65,6 +65,8 @@ section for the next release.
 - maespa did not compile with new fortran compiler
 - updated github action to build docker images
 - PEcAn.SIPNET now accepts relative paths in its input XML (#3418). Previously all files referenced in the autogenerated `job.sh` needed to be specified as absolute paths.
+- Refactored and created new version of `SDA_downscale` named `ensemble_downscale`.
+- Added helper function `.convert_coords_to_sf()` for consistent conversion of data with lat lon data to `sf` pts.
 - R version 4.4 installs Python 3.12 which wants to leverage os managed packages instead, install python3-pika using apt.
 
 ### Changed

modules/assim.sequential/DESCRIPTION

@@ -41,7 +41,9 @@ Suggests:
     ggrepel,
     glue,
     ggpubr,
+    ggrepel,
     gridExtra,
+    keras3 (>= 1.0.0),
     itertools,
     magic (>= 1.5.0),
     methods,
@@ -53,18 +55,18 @@ Suggests:
     plotrix,
     plyr (>= 1.8.4),
     randomForest,
-    keras3 (>= 1.0.0),
+    ranger,
     raster,
     readr,
     reshape2 (>= 1.4.2),
     rlist,
     sf,
+    sp,
     stats,
     terra,
     testthat,
     tictoc,
     tidyr,
-    sp,
     utils,
     xgboost,
     XML

modules/assim.sequential/NAMESPACE

@@ -29,8 +29,10 @@ export(assessParams)
 export(block_matrix)
 export(conj_wt_wishart_sampler)
 export(construct_nimble_H)
+export(downscale_metrics)
 export(downscale_qsub_main)
 export(dwtmnorm)
+export(ensemble_downscale)
 export(get_ensemble_weights)
 export(hop_test)
 export(interactive.plotting.sda)
@@ -60,6 +62,7 @@ export(sda.enkf_local)
 export(sda_assemble)
 export(sda_weights_site)
 export(simple.local)
+export(subset_ensemble)
 export(stack_covariates_2_geotiff)
 export(tobit.model)
 export(tobit2space.model)

modules/assim.sequential/R/Helper.functions.R

@@ -6,10 +6,10 @@
 #' @description This function performs a simple outlier replacement on all the columns of dataframes inside a list
 #' @return A list the same dimension as X, with each column of each dataframe
 #'   modified by replacing outlier points with the column median
-#' @export
+#' @export outlier.detector.boxplot
 #' @importFrom magrittr %>%
 #'
-outlier.detector.boxplot<-function(X) {
+outlier.detector.boxplot <- function(X) {
   X <- X  %>% 
     purrr::map(function(X.tmp){
       #X.tmp is all the state variables for each element of the list (site)