PMM-7 use only own library

Author: ademidoff

pmm/v3/pmm3-aws-staging-start.groovy

@@ -3,11 +3,6 @@ import hudson.slaves.*
 import jenkins.model.Jenkins
 import hudson.plugins.sshslaves.SSHLauncher
 
-library changelog: false, identifier: 'lib@master', retriever: modernSCM([
-    $class: 'GitSCMSource',
-    remote: 'https://github.com/Percona-Lab/jenkins-pipelines.git'
-]) _
-
 library changelog: false, identifier: 'v3lib@PMM-7-refactor-launch-spot-instance-fn', retriever: modernSCM(
   scm: [$class: 'GitSCMSource', remote: 'https://github.com/Percona-Lab/jenkins-pipelines.git'],
   libraryPath: 'pmm/v3/'

pmm/v3/vars/getPMMBuildParams.groovy

@@ -0,0 +1,35 @@
+/**
+ * Get the build params used to idenify the VM_NAME, the build author and their slackUserId.
+ * Those are quite helpful when we analyze the resource consumption and ownership.
+ * 
+ * Returns: 
+    - VM_NAME(String): a unique virtual machine name
+    - OWNER(String): the owner or author of the build (cat take the valur of 'timer' if triggered by the timer)
+    - OWNER_SLACK(String): slackUserId or null if impossible to extract it
+ *
+ * Side effects: it will set the relevant envvars so the developer does not have to.
+**/
+
+def call(String VM_PREFIX) {
+    String VM_NAME = '';
+    String OWNER = '';
+    String OWNER_SLACK = '';
+
+    if (!VM_PREFIX) {
+        error "Error: 'VM_PREFIX' must be a non-empty string"
+    }
+
+    wrap([$class: 'BuildUser']) {
+        // ONWER => BUILD_USER or BUILD_USER_ID or CHANGE_AUTHOR or CHANGE_ID
+        OWNER = (env.BUILD_USER_EMAIL ?: '').split('@')[0] ?: (env.BUILD_USER_ID ?: (env.CHANGE_AUTHOR ?: env.CHANGE_ID))
+        OWNER = OWNER ?: 'system'
+        OWNER_SLACK = slackUserIdFromEmail(botUser: true, email: env.BUILD_USER_EMAIL ?: env.CHANGE_AUTHOR_EMAIL, tokenCredentialId: 'JenkinsCI-SlackBot-v2')
+        VM_NAME = VM_PREFIX + OWNER.replaceAll("[^a-zA-Z0-9_.-]", "") + '-' + (new Date()).format("yyyyMMdd.HHmmss") + '-' + env.BUILD_NUMBER
+    }
+
+    env.VM_NAME = VM_NAME
+    env.OWNER = OWNER
+    env.OWNER_SLACK = OWNER_SLACK
+
+    return [ VM_NAME, OWNER, OWNER_SLACK ];
+}

pmm/v3/vars/runSpotInstance.groovy

@@ -25,7 +25,7 @@ def call(String INSTANCE_TYPE) {
             )
             SPOT_PRICE=$(
                 aws ec2 describe-spot-price-history \
-                    --instance-types ${INSTANCE_TYPE} \
+                    --instance-types $INSTANCE_TYPE \
                     --region us-east-2 \
                     --output text \
                     --product-description "Linux/UNIX (Amazon VPC)" \
@@ -46,7 +46,7 @@ def call(String INSTANCE_TYPE) {
                     "LaunchSpecification": {
                         "EbsOptimized": false,
                         "ImageId": "$IMAGE_ID",
-                        "InstanceType": "${INSTANCE_TYPE}",
+                        "InstanceType": "$INSTANCE_TYPE",
                         "KeyName": "jenkins",
                         "Monitoring": {
                             "Enabled": false