Skip to content

Commit 838744c

Browse files
committed
t/run/todo.t: Add comments
Make clarifications about this file and add a list of issues that we don't need TODO tests for, so that someone doesn't waste their efforts.
1 parent f1c1ca7 commit 838744c

File tree

1 file changed

+73
-11
lines changed

1 file changed

+73
-11
lines changed

t/run/todo.t

Lines changed: 73 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,80 @@
11
#!./perl
22

3-
# This file is a place for tests that fail at the time they are added here.
3+
# This file is a place for tests that are failing at the time they are added
4+
# into this file. It exists so that anyone can contribute a test without
5+
# having to know about Perl's testing internal structures.
46
#
5-
# When a ticket is filed, just follow the paradigm(s) in this file to add a
6-
# test that shows the failure.
7+
# These introductory comments include hints that may be revised from time to
8+
# time as we gain experience with what sorts of things people find confusing.
9+
# Therefore it is a good idea to check what's changed since the last time you
10+
# looked.
711
#
8-
# It is expected that when new tickets are opened, some will actually be
9-
# duplicates of existing known bad behavior. And since there are so many open
10-
# tickets, we might overlook that. If there is a test here, we would
11-
# automatically discover that a fix for the newer ticket actually fixed an
12-
# earlier one (or ones) as well. Thus the issue can be closed, and the final
13-
# disposition of the test here determined at that time. (For example, perhaps
14-
# it is redundant to the test demonstrating the bug that was intentionally
15-
# fixed, so can be removed altogether.)
12+
# To add a test, create a new
13+
# TODO: {
14+
# local $::TODO = "GH #####";
15+
# ...
16+
# }
17+
#
18+
# block, like the ones already here. We want to keep the blocks sorted by
19+
# GitHub issue number so that it is easier to check if there already is a test
20+
# for the one you are intending to add.
21+
#
22+
# This file uses the test functionality from t/test.pl. For the most part,
23+
# these look like the ones that Test::More offers, 'is', 'like', and so forth,
24+
# along with a few extras to handle the case where the failure crashes the
25+
# perl interpreter. The ones whose names start with 'fresh' require a
26+
# significant amount of sophistication to use correctly. It's best to start
27+
# out, if possible, by avoiding issues that crash the interpreter and need
28+
# these.
29+
30+
# Some domains have infrastructure which may make it easier to add a test
31+
# there, than to have to set up things here. These include:
32+
#
33+
# Domain Test File
34+
# deparsing lib/B/Deparse.t
35+
# regex matching t/re/re_tests
36+
#
37+
# Before you add a test here, check that the ticket isn't one of these,
38+
# because we already have todo tests for them (in some other file).
39+
#
40+
# Git Hub issue numbers
41+
# 2207
42+
# 2208
43+
# 2286
44+
# 2931
45+
# 4125
46+
# 4261
47+
# 4370
48+
# 5959
49+
# 8267
50+
# 8945
51+
# 8952
52+
# 9010
53+
# 9406
54+
# 10750
55+
# 14052
56+
# 14630
57+
# 19370
58+
# 19661
59+
# 22547
60+
#
61+
# We keep a list of all the people who have contributed to the Perl 5 project.
62+
# If this is your first time contributing, you will need to add your name to
63+
# this list. After you have changed this file with your new test and
64+
# committed the result, run
65+
#
66+
# perl Porting/updateAUTHORS.pl
67+
#
68+
# This will automatically add you (if you weren't there already) to our list
69+
# of contributors. If so, you will need to commit this change by doing
70+
# something like:
71+
#
72+
# commit -a -m'[your name here] is now a Perl 5 author'
73+
#
74+
# Adding tests here helps in two ways. It might show that the bug has already
75+
# been fixed and we just don't know it; or skimming the existing tests here
76+
# might show that there is an existing ticket already open, and the new ticket
77+
# can be marked as duplicate.
1678

1779
BEGIN {
1880
chdir 't' if -d 't';

0 commit comments

Comments
 (0)