-
Notifications
You must be signed in to change notification settings - Fork 589
t/run/todo.t Add list of tickets we don't need tests for #23518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this really is the best approach..
My expectation is that the list of issue numbers will become out-of-sync and won't be updated when new todo tests are added in other files..
A possible alternative: update the TODO-tests that uses RT/perl numbers and replace (or add) the GitHub numbers and change this to include something like:
(A starting point for the old RT numbers:
git grep -E 'TODO.*(perl|RT)[[:space:]]*#' t/ dist/ ext/
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think it is the best approach at this time. I will be watching for this getting outdated and take steps to make sure it doesn't. And that won't require very much work as it is quite rare for a TODO test to get added that isn't quickly removed. One set was added by @iabyn a year ago as a result of his reworking the XS parsing. The previous instance was a year before that via 981e5d6
I'm now reluctant to use GH as a prefix to ticket numbers, as it seems to break their automatic closing by the system when a p.r. gets merged that refers to a ticket with that prefix.
The list was created by me by going through the code, looking for every extant use of todo. It should be complete as of now, and no one is going to add anything new for things that use non-GH numbering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I'm trying to make this as simple as possible so people thinking of contributing have as little extra steps to take as possible