From 30c1d5cb82c94b1da7a0bacf1726dd43e46c51a0 Mon Sep 17 00:00:00 2001
From: Guanxiao Qi <944843236@qq.com>
Date: Thu, 17 Jul 2025 16:57:31 +0800
Subject: [PATCH 1/3] add some lint tools

---
 example_external/CMakeLists.txt | 6 ++++++
 example_external/package.xml    | 6 +++++-
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/example_external/CMakeLists.txt b/example_external/CMakeLists.txt
index 8ab3d38..dc31603 100644
--- a/example_external/CMakeLists.txt
+++ b/example_external/CMakeLists.txt
@@ -49,4 +49,10 @@ install(
 
 ament_export_targets(export_generate_parameter_library_example_external HAS_LIBRARY_TARGET)
 ament_export_dependencies(rclcpp rclcpp_components generate_parameter_library_example)
+
+if(BUILD_TESTING)
+  find_package(ament_lint_auto REQUIRED)
+  ament_lint_auto_find_test_dependencies()
+endif()
+
 ament_package()
diff --git a/example_external/package.xml b/example_external/package.xml
index 76d0a48..1339381 100644
--- a/example_external/package.xml
+++ b/example_external/package.xml
@@ -19,7 +19,11 @@
   <buildtool_export_depend>ament_cmake_core</buildtool_export_depend>
 
   <test_depend>ament_lint_auto</test_depend>
-  <test_depend>ament_lint_common</test_depend>
+  <test_depend>ament_cmake_lint_cmake</test_depend>
+  <test_depend>ament_cmake_cpplint</test_depend>
+  <test_depend>ament_cmake_cppcheck</test_depend>
+  <test_depend>ament_cmake_xmllint</test_depend>
+  <test_depend>ament_cmake_copyright</test_depend>
 
   <export>
     <build_type>ament_cmake</build_type>

From 251a8a166abbc9bcc3c3be1d7029bb583b319add Mon Sep 17 00:00:00 2001
From: Guanxiao Qi <944843236@qq.com>
Date: Thu, 17 Jul 2025 18:10:31 +0800
Subject: [PATCH 2/3] fix the cpplint errors

---
 .../minimal_publisher_external.hpp                             | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/example_external/include/generate_parameter_library_example_external/minimal_publisher_external.hpp b/example_external/include/generate_parameter_library_example_external/minimal_publisher_external.hpp
index cfca521..a926f03 100644
--- a/example_external/include/generate_parameter_library_example_external/minimal_publisher_external.hpp
+++ b/example_external/include/generate_parameter_library_example_external/minimal_publisher_external.hpp
@@ -28,6 +28,7 @@
 
 #pragma once
 
+#include <memory>
 #include <rclcpp/rclcpp.hpp>
 #include <rclcpp_components/register_node_macro.hpp>
 
@@ -37,7 +38,7 @@ namespace admittance_controller {
 
 class MinimalPublisher : public rclcpp::Node {
  public:
-  MinimalPublisher(const rclcpp::NodeOptions& options = rclcpp::NodeOptions());
+  explicit MinimalPublisher(const rclcpp::NodeOptions& options = rclcpp::NodeOptions());
 
  private:
   void timer_callback();

From e6d55bfc3655f7e6ce5032a0444d439008d93782 Mon Sep 17 00:00:00 2001
From: Guanxiao Qi <944843236@qq.com>
Date: Thu, 17 Jul 2025 18:44:16 +0800
Subject: [PATCH 3/3] fix the copyright errors

---
 .../minimal_publisher_external.hpp                            | 4 ++++
 example_external/src/minimal_publisher_external.cpp           | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/example_external/include/generate_parameter_library_example_external/minimal_publisher_external.hpp b/example_external/include/generate_parameter_library_example_external/minimal_publisher_external.hpp
index a926f03..9a94120 100644
--- a/example_external/include/generate_parameter_library_example_external/minimal_publisher_external.hpp
+++ b/example_external/include/generate_parameter_library_example_external/minimal_publisher_external.hpp
@@ -1,5 +1,9 @@
 // Copyright 2025 Forssea Robotics
 //
+// All rights reserved.
+//
+// Software License Agreement (BSD License 2.0)
+//
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are met:
 //
diff --git a/example_external/src/minimal_publisher_external.cpp b/example_external/src/minimal_publisher_external.cpp
index bf2396b..d2a6eac 100644
--- a/example_external/src/minimal_publisher_external.cpp
+++ b/example_external/src/minimal_publisher_external.cpp
@@ -1,5 +1,9 @@
 // Copyright 2025 Forssea Robotics
 //
+// All rights reserved.
+//
+// Software License Agreement (BSD License 2.0)
+//
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are met:
 //