Skip to content

Conversation

@simsong
Copy link
Member

@simsong simsong commented Nov 17, 2025

No description provided.

@simsong simsong linked an issue Nov 17, 2025 that may be closed by this pull request
1 task
@simsong
Copy link
Member Author

simsong commented Nov 19, 2025

@copilot --- please fix this so that unzipit-worker.module.js and unzipit.module.js are ignored in the eslint config file, not in the .eslintignore file. Please modify the config file so that it specifies *.js as the files to check and remove the for loop in the Makefile in src/app/static. Finally, please change the modules so that they have a .mjs extension and update all of the HTML templates and other files as necessary.

Copy link
Contributor

Copilot AI commented Nov 19, 2025

@simsong I've opened a new pull request, #799, to work on those changes. Once the pull request is ready, I'll request review from you.

@simsong
Copy link
Member Author

simsong commented Nov 19, 2025

@copilot - you did a great job on the lint warnings. Now we have problems with pytest failing. Can you take a look and submit a PR that solves these problems? You will likely need to fix the tests, not the source code. Recall that the big change that we made was removing jquery. https://github.com/Plant-Tracer/webapp/actions/runs/19502020082/job/55818255510?pr=797

Copy link
Contributor

Copilot AI commented Nov 19, 2025

@simsong I've opened a new pull request, #800, to work on those changes. Once the pull request is ready, I'll request review from you.

@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

❌ Patch coverage is 79.51220% with 42 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.45%. Comparing base (5bb964a) to head (92829db).
⚠️ Report is 44 commits behind head on main.

Files with missing lines Patch % Lines
src/app/static/planttracer.js 35.00% 24 Missing and 2 partials ⚠️
tests/canvas_movie_controller_test.py 88.65% 11 Missing ⚠️
tests/integration/test_api_gateway.py 0.00% 2 Missing ⚠️
src/app/static/users.js 50.00% 1 Missing ⚠️
standalone.py 0.00% 1 Missing ⚠️
tests/app_test.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #797      +/-   ##
==========================================
+ Coverage   78.78%   79.45%   +0.66%     
==========================================
  Files          41       42       +1     
  Lines        4361     4420      +59     
  Branches       97       99       +2     
==========================================
+ Hits         3436     3512      +76     
+ Misses        907      889      -18     
- Partials       18       19       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@simsong simsong requested a review from Copilot November 19, 2025 15:38
Copy link
Contributor

Copilot AI commented Nov 19, 2025

@simsong I've opened a new pull request, #801, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link
Contributor

Copilot AI commented Nov 19, 2025

@simsong I've opened a new pull request, #802, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI and others added 15 commits November 19, 2025 17:37
Add Selenium/Chromium test infrastructure for canvas_movie_controller.js
@simsong simsong marked this pull request as ready for review November 21, 2025 18:27
@simsong
Copy link
Member Author

simsong commented Nov 21, 2025

@copilot @sbarber2 this is finally ready for your review.

Copy link
Contributor

Copilot AI commented Nov 21, 2025

@simsong I've opened a new pull request, #803, to work on those changes. Once the pull request is ready, I'll request review from you.

Remove jQuery dependency from PlantTracer application
@simsong simsong merged commit 2723b4f into main Nov 21, 2025
6 checks passed
@simsong simsong deleted the 773-ditch-jquery branch November 21, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ditch jquery

3 participants