Merge pull request #70 from Pocket/MC-730

chore: [MC-730] Remove references to timeToRead

Author: nina-py

src/api/desktop/recent-saves/response.ts

@@ -35,7 +35,6 @@ const reduceGraphItem = (savedItem: GraphSavedItem): Save => {
     excerpt: nestedItem.excerpt,
     domain: nestedItem.domain,
     wordCount: nestedItem.wordCount,
-    timeToRead: nestedItem.timeToRead,
     topImageUrl: nestedItem?.topImage?.url ?? null,
   };
 };

src/api/desktop/recommendations/recommendations.spec.ts

@@ -85,8 +85,5 @@ describe('recommendations API server', () => {
     expect(recommendation.tileId).toEqual(
       mockResponse.newTabSlate.recommendations[0].tileId
     );
-    if (recommendation.timeToRead !== undefined) {
-      expect(recommendation.timeToRead).toBeGreaterThanOrEqual(1);
-    }
   });
 });

src/api/desktop/recommendations/response.spec.ts

@@ -43,8 +43,6 @@ describe('response', () => {
             `utm_source=${graphResponse.newTabSlate.utmSource}`
           )
         ).toBeTruthy();
-        expect(res.data[0].timeToRead).toBeUndefined();
-        expect(res.data[1].timeToRead).toBeUndefined();
       } else {
         throw validate.errors;
       }

src/generated/graphql/types.ts

@@ -20,7 +20,6 @@ query RecentSaves($pagination: PaginationInput) {
                 url
               }
               title
-              timeToRead
               resolvedUrl
               givenUrl
               excerpt
@@ -31,4 +30,4 @@ query RecentSaves($pagination: PaginationInput) {
       }
     }
   }
-}
+}

src/graphql-proxy/recent-saves/RecentSaves.graphql

@@ -31,7 +31,6 @@ const fakeSaves = (count): RecentSavesQuery['user']['savedItems']['edges'] => {
             url: common.itemImage(),
           },
           title: common.itemTitle(),
-          timeToRead: faker.datatype.number({ max: 15 }),
           resolvedUrl: common.itemUrl(),
           givenUrl: common.itemUrl(),
           excerpt: common.itemExcerpt(),

src/graphql-proxy/recent-saves/__mocks__/recent-saves.ts

@@ -10,7 +10,6 @@ query NewTabRecommendations($locale: String!, $region: String, $count: Int) {
         publisher
         title
         url
-        # timeToRead
       }
     }
   }

src/graphql-proxy/recommendations/Recommendations.graphql

@@ -28,12 +28,9 @@ const fakerLocales = {
   it: 'it',
 };
 
-/**
- *
- * @param hasTimeToRead If true, timeToRead is set to [1, 9], otherwise it's undefined.
- */
-const fakeRecommendation = (hasTimeToRead = true): GraphRecommendation => {
-  const recommendationWithoutTimeToRead: GraphRecommendation = {
+
+const fakeRecommendation = (): GraphRecommendation => {
+  const recommendation: GraphRecommendation = {
     __typename: 'CorpusRecommendation',
     id: faker.datatype.uuid(),
     tileId: faker.datatype.number(),
@@ -46,7 +43,7 @@ const fakeRecommendation = (hasTimeToRead = true): GraphRecommendation => {
     },
   };
 
-  return recommendationWithoutTimeToRead;
+  return recommendation;
 };
 
 const fakeRecommendations = (
@@ -55,8 +52,7 @@ const fakeRecommendations = (
   return Array(count)
     .fill(0)
     .map((value, index) =>
-      // Add timeToRead only for even numbered recommendations.
-      fakeRecommendation(index % 2 === 0)
+      fakeRecommendation()
     );
 };