Merge pull request #68 from Pocket/delete-comments-from-incident

(chore) Remove code that was commented out during the recent incident

Author: efixler

src/api/desktop/recommendations/response.spec.ts

@@ -43,11 +43,7 @@ describe('response', () => {
             `utm_source=${graphResponse.newTabSlate.utmSource}`
           )
         ).toBeTruthy();
-        // Even recommendations have timeToRead mocked to [1, 9].
-        //expect(res.data[0].timeToRead).toBeGreaterThanOrEqual(1);
-        //expect(res.data[0].timeToRead).toBeLessThanOrEqual(9);
         expect(res.data[0].timeToRead).toBeUndefined();
-        // Odd recommendations have timeToRead mocked to undefined.
         expect(res.data[1].timeToRead).toBeUndefined();
       } else {
         throw validate.errors;

src/api/desktop/recommendations/response.ts

@@ -58,13 +58,6 @@ export const mapRecommendation = (
     imageUrl: recommendation.corpusItem.imageUrl,
   };
 
-  // if (recommendation.corpusItem.timeToRead) {
-  //   return {
-  //     ...recommendationToReturn,
-  //     timeToRead: recommendation.corpusItem.timeToRead,
-  //   };
-  // }
-
   return recommendationToReturn;
 };
 

src/api/v3/response.spec.ts

@@ -43,11 +43,7 @@ describe('response', () => {
             `utm_source=${graphResponse.newTabSlate.utmSource}`
           )
         ).toBeTruthy();
-        // Even recommendations have timeToRead mocked to [1, 9].
-        // expect(res.recommendations[0].time_to_read).toBeGreaterThanOrEqual(1);
-        // expect(res.recommendations[0].time_to_read).toBeLessThanOrEqual(9);
         expect(res.recommendations[0].time_to_read).toBeUndefined();
-        // Odd recommendations have timeToRead mocked to undefined.
         expect(res.recommendations[1].time_to_read).toBeUndefined();
       } else {
         throw validate.errors;

src/api/v3/response.ts

@@ -37,13 +37,6 @@ export const mapRecommendation = (
     image_src: `https://img-getpocket.cdn.mozilla.net/direct?url=${encodedImageUrl}&resize=w450`,
   };
 
-  // if (recommendation.corpusItem.timeToRead) {
-  //   return {
-  //     ...feedItemToReturn,
-  //     time_to_read: recommendation.corpusItem.timeToRead,
-  //   };
-  // }
-
   return feedItemToReturn;
 };
 

src/generated/graphql/types.ts

@@ -26,6 +26,21 @@ export type Scalars = {
   Url: any;
 };
 
+/**
+ * Input data for adding multiple items to a list.
+ * Appends to the end of the list.
+ */
+export type AddItemInput = {
+  authors?: InputMaybe<Scalars['String']>;
+  excerpt?: InputMaybe<Scalars['String']>;
+  imageUrl?: InputMaybe<Scalars['Url']>;
+  itemId: Scalars['ID'];
+  note?: InputMaybe<Scalars['String']>;
+  publisher?: InputMaybe<Scalars['String']>;
+  title?: InputMaybe<Scalars['String']>;
+  url: Scalars['Url'];
+};
+
 export type AdvancedSearchFilters = {
   contentType?: InputMaybe<SearchItemsContentType>;
   domain?: InputMaybe<Scalars['String']>;
@@ -801,6 +816,26 @@ export type ListElement = {
   level: Scalars['Int'];
 };
 
+/** The Connection type for ListItem */
+export type ListItemConnection = {
+  __typename?: 'ListItemConnection';
+  /** A list of edges. */
+  edges?: Maybe<Array<ListItemEdge>>;
+  /** Information to aid in pagination. */
+  pageInfo: PageInfo;
+  /** Identifies the total count of SavedItems in the connection. */
+  totalCount: Scalars['Int'];
+};
+
+/** An Edge in a Connection */
+export type ListItemEdge = {
+  __typename?: 'ListItemEdge';
+  /** A cursor for use in pagination. */
+  cursor: Scalars['String'];
+  /** The ListItem at the end of the edge. */
+  node: ShareableListItem;
+};
+
 export type MarkdownImagePosition = {
   __typename?: 'MarkdownImagePosition';
   index: Scalars['Int'];
@@ -874,11 +909,15 @@ export type MarticleText = {
 /** Default Mutation Type */
 export type Mutation = {
   __typename?: 'Mutation';
+  /** Add a batch of items to an existing shareable list. */
+  addToShareableList: ShareableList;
   /**
    * Make requests to create and delete highlights in a single batch.
    * Mutation is atomic -- if there is a response, all operations were successful.
    */
   batchWriteHighlights: BatchWriteHighlightsResult;
+  /** Add a batch of items to an existing shareable list. */
+  createAndAddToShareableList?: Maybe<ShareableList>;
   /** Create new highlight note. Returns the data for the created Highlight note. */
   createSavedItemHighlightNote?: Maybe<HighlightNote>;
   /** Create new highlight annotation(s). Returns the data for the created Highlight object(s). */
@@ -1092,12 +1131,26 @@ export type Mutation = {
 };
 
 
+/** Default Mutation Type */
+export type MutationAddToShareableListArgs = {
+  items: Array<AddItemInput>;
+  listExternalId: Scalars['ID'];
+};
+
+
 /** Default Mutation Type */
 export type MutationBatchWriteHighlightsArgs = {
   input?: InputMaybe<BatchWriteHighlightsInput>;
 };
 
 
+/** Default Mutation Type */
+export type MutationCreateAndAddToShareableListArgs = {
+  itemData: Array<AddItemInput>;
+  listData: CreateShareableListInput;
+};
+
+
 /** Default Mutation Type */
 export type MutationCreateSavedItemHighlightNoteArgs = {
   id: Scalars['ID'];
@@ -1440,6 +1493,14 @@ export type NumberedListElement = ListElement & {
   level: Scalars['Int'];
 };
 
+/** Input for offset-pagination (internal backend use only). */
+export type OffsetPaginationInput = {
+  /**  Defaults to 30  */
+  limit?: InputMaybe<Scalars['Int']>;
+  /**  Defaults to 0  */
+  offset?: InputMaybe<Scalars['Int']>;
+};
+
 /** Information about pagination in a connection. */
 export type PageInfo = {
   __typename?: 'PageInfo';
@@ -2228,6 +2289,15 @@ export type SavedItemsFilter = {
   updatedSince?: InputMaybe<Scalars['Int']>;
 };
 
+/** A page of SavedItems, retrieved by offset-based pagination. */
+export type SavedItemsPage = {
+  __typename?: 'SavedItemsPage';
+  entries: Array<SavedItem>;
+  limit: Scalars['Int'];
+  offset: Scalars['Int'];
+  totalCount: Scalars['Int'];
+};
+
 /** Input to sort fetched SavedItems. If unspecified, defaults to CREATED_AT, ASC. */
 export type SavedItemsSort = {
   /** The field by which to sort SavedItems */
@@ -2439,9 +2509,14 @@ export type ShareableList = {
   description?: Maybe<Scalars['String']>;
   /** A unique string identifier in UUID format. */
   externalId: Scalars['ID'];
+  /** Pocket Saves that have been added to this list by the Pocket user. */
+  items: ListItemConnection;
   /** The visibility of notes added to list items for this list. */
   listItemNoteVisibility: ShareableListVisibility;
-  /** Pocket Saves that have been added to this list by the Pocket user. */
+  /**
+   * Pocket Saves that have been added to this list by the Pocket user.
+   * @deprecated use items
+   */
   listItems: Array<ShareableListItem>;
   /** The moderation status of the list. Defaults to VISIBLE. */
   moderationStatus: ShareableListModerationStatus;
@@ -2463,6 +2538,12 @@ export type ShareableList = {
   user: User;
 };
 
+
+/** A user-created list of Pocket saves that can be shared publicly. */
+export type ShareableListItemsArgs = {
+  pagination?: InputMaybe<PaginationInput>;
+};
+
 /** A Pocket Save (story) that has been added to a Shareable List. */
 export type ShareableListItem = {
   __typename?: 'ShareableListItem';
@@ -2942,6 +3023,8 @@ export type User = {
   savedItemById?: Maybe<SavedItem>;
   /** Get a general paginated listing of all SavedItems for the user */
   savedItems?: Maybe<SavedItemConnection>;
+  /** Fetch SavedItems with offset pagination. Internal backend use only. */
+  savedItemsByOffset?: Maybe<SavedItemsPage>;
   /**
    * Premium search query. Name will be updated after client input
    * @deprecated Use searchSavedItems
@@ -2985,6 +3068,14 @@ export type UserSavedItemsArgs = {
 };
 
 
+/** Resolve by reference the User entity in this graph to provide user data with public lists. */
+export type UserSavedItemsByOffsetArgs = {
+  filter?: InputMaybe<SavedItemsFilter>;
+  pagination?: InputMaybe<OffsetPaginationInput>;
+  sort?: InputMaybe<SavedItemsSort>;
+};
+
+
 /** Resolve by reference the User entity in this graph to provide user data with public lists. */
 export type UserSearchArgs = {
   params: SearchParams;

src/graphql-proxy/recommendations/__mocks__/recommendations.ts

@@ -47,17 +47,6 @@ const fakeRecommendation = (hasTimeToRead = true): GraphRecommendation => {
   };
 
   return recommendationWithoutTimeToRead;
-  // if (!hasTimeToRead) {
-  //   return recommendationWithoutTimeToRead;
-  // }
-
-  // return {
-  // ...recommendationWithoutTimeToRead,
-  // corpusItem: {
-  //   ...recommendationWithoutTimeToRead.corpusItem,
-  //   timeToRead: faker.datatype.number({ min: 1, max: 9 }),
-  // },
-  // };
 };
 
 const fakeRecommendations = (