Skip to content

Conversation

@EDsCODE
Copy link
Collaborator

@EDsCODE EDsCODE commented Jul 17, 2025

Problem

  • stripe invoices for our team still erroring our majority of the time

Changes

  • increase network retries

How did you test this code?

Did you write or update any docs for this change?


👉 Stay up-to-date with PostHog coding conventions for a smoother review.

@EDsCODE EDsCODE requested a review from a team July 17, 2025 19:35
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR makes a simple but important change to improve the reliability of Stripe invoice data imports. The change increases the max_network_retries parameter for the Stripe client from 3 to 5 attempts in the temporal data imports pipeline. This change is specifically targeted at addressing frequent failures when retrieving invoice data.

This parameter is part of the Stripe client configuration and determines how many times a failed network request will be automatically retried before giving up. The increase from 3 to 5 retries gives the system more opportunities to succeed in case of temporary network issues or Stripe API hiccups.

Confidence score: 5/5

  1. This is a very safe change that only affects retry behavior for failed requests
  2. The change is minimal, well-isolated, and follows Stripe's best practices for handling network errors
  3. No files need special attention - the change is straightforward and its effects are clear

1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

@phixMe phixMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥉 --> 5️⃣

@EDsCODE EDsCODE enabled auto-merge (squash) July 18, 2025 14:45
@EDsCODE EDsCODE merged commit 8c5e476 into master Jul 18, 2025
219 of 220 checks passed
@EDsCODE EDsCODE deleted the stripe-import-network-retry-4 branch July 18, 2025 16:20
lricoy pushed a commit that referenced this pull request Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants