connect output to result

SteveL-MSFT · SteveL-MSFT · commit 4f23c0f6652c · 2025-10-20T15:35:22.000-07:00
diff --git a/lib/dsc-lib/locales/en-us.toml b/lib/dsc-lib/locales/en-us.toml
@@ -79,6 +79,11 @@ nameResultNotString = "Resource name result is not a string"
 circularDependency = "Circular dependency or unresolvable parameter references detected in parameters: %{parameters}"
 userFunctionAlreadyDefined = "User function '%{name}' in namespace '%{namespace}' is already defined"
 addingUserFunction = "Adding user function '%{name}'"
+skippingOutput = "Skipping output for '%{name}' due to condition evaluating to false"
+outputValueNotDefined = "Output value '%{name}' is not defined"
+secureOutputSkipped = "Secure output '%{name}' is skipped"
+outputTypeNotMatched = "Output '%{name}' type does not match expected type '%{expected_type}'"
+copyNotSupported = "Copy for output '%{name}' is currently not supported"
 
 [discovery.commandDiscovery]
 couldNotReadSetting = "Could not read 'resourcePath' setting"
diff --git a/lib/dsc-lib/src/configure/config_doc.rs b/lib/dsc-lib/src/configure/config_doc.rs
@@ -7,6 +7,7 @@ use schemars::{JsonSchema, json_schema};
 use serde::{Deserialize, Serialize};
 use serde_json::{Map, Value};
 use std::{collections::HashMap, fmt::Display};
+use std::fmt::Display;
 
 use crate::{dscerror::DscError, schemas::DscRepoSchema};
 
diff --git a/lib/dsc-lib/src/configure/config_result.rs b/lib/dsc-lib/src/configure/config_result.rs
@@ -3,6 +3,7 @@
 
 use schemars::JsonSchema;
 use serde::{Deserialize, Serialize};
+use serde_json::{Map, Value};
 use crate::dscresources::invoke_result::{GetResult, SetResult, TestResult};
 use crate::configure::config_doc::{Configuration, Metadata};
 
@@ -54,6 +55,8 @@ pub struct ConfigurationGetResult {
     pub messages: Vec<ResourceMessage>,
     #[serde(rename = "hadErrors")]
     pub had_errors: bool,
+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub outputs: Option<Map<String, Value>>,
 }
 
 impl ConfigurationGetResult {
@@ -64,6 +67,7 @@ impl ConfigurationGetResult {
             results: Vec::new(),
             messages: Vec::new(),
             had_errors: false,
+            outputs: None,
         }
     }
 }
@@ -85,6 +89,7 @@ impl From<ConfigurationTestResult> for ConfigurationGetResult {
             results,
             messages: test_result.messages,
             had_errors: test_result.had_errors,
+            outputs: test_result.outputs,
         }
     }
 }
@@ -140,6 +145,8 @@ pub struct ConfigurationSetResult {
     pub messages: Vec<ResourceMessage>,
     #[serde(rename = "hadErrors")]
     pub had_errors: bool,
+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub outputs: Option<Map<String, Value>>,
 }
 
 impl ConfigurationSetResult {
@@ -150,6 +157,7 @@ impl ConfigurationSetResult {
             results: Vec::new(),
             messages: Vec::new(),
             had_errors: false,
+            outputs: None,
         }
     }
 }
@@ -200,6 +208,8 @@ pub struct ConfigurationTestResult {
     pub messages: Vec<ResourceMessage>,
     #[serde(rename = "hadErrors")]
     pub had_errors: bool,
+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub outputs: Option<Map<String, Value>>,
 }
 
 impl ConfigurationTestResult {
@@ -210,6 +220,7 @@ impl ConfigurationTestResult {
             results: Vec::new(),
             messages: Vec::new(),
             had_errors: false,
+            outputs: None,
         }
     }
 }
@@ -228,6 +239,8 @@ pub struct ConfigurationExportResult {
     pub messages: Vec<ResourceMessage>,
     #[serde(rename = "hadErrors")]
     pub had_errors: bool,
+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub outputs: Option<Map<String, Value>>,
 }
 
 impl ConfigurationExportResult {
@@ -238,6 +251,7 @@ impl ConfigurationExportResult {
             result: None,
             messages: Vec::new(),
             had_errors: false,
+            outputs: None,
         }
     }
 }
diff --git a/lib/dsc-lib/src/configure/context.rs b/lib/dsc-lib/src/configure/context.rs
@@ -36,6 +36,7 @@ pub struct Context {
     pub system_root: PathBuf,
     pub user_functions: HashMap<String, UserFunctionDefinition>,
     pub variables: Map<String, Value>,
+    pub outputs: Map<String, Value>,
 }
 
 impl Context {
@@ -61,6 +62,8 @@ impl Context {
             system_root: get_default_os_system_root(),
             user_functions: HashMap::new(),
             variables: Map::new(),
+            restart_required: None,
+            outputs: Map::new(),
         }
     }
 }
diff --git a/lib/dsc-lib/src/configure/mod.rs b/lib/dsc-lib/src/configure/mod.rs
@@ -1,9 +1,8 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
-use crate::configure::config_doc::{ExecutionKind, Metadata, Resource, Parameter};
 use crate::configure::context::{Context, ProcessMode};
-use crate::configure::{config_doc::RestartRequired, parameters::Input};
+use crate::configure::{config_doc::{ExecutionKind, Metadata, Parameter, Resource, RestartRequired, ValueOrCopy}, parameters::Input};
 use crate::discovery::discovery_trait::DiscoveryFilter;
 use crate::dscerror::DscError;
 use crate::dscresources::{
@@ -413,6 +412,10 @@ impl Configurator {
         result.metadata = Some(
             self.get_result_metadata(Operation::Get)
         );
+        self.process_output()?;
+        if !self.context.outputs.is_empty() {
+            result.outputs = Some(self.context.outputs.clone());
+        }
         Ok(result)
     }
 
@@ -584,6 +587,10 @@ impl Configurator {
         result.metadata = Some(
             self.get_result_metadata(Operation::Set)
         );
+        self.process_output()?;
+        if !self.context.outputs.is_empty() {
+            result.outputs = Some(self.context.outputs.clone());
+        }
         Ok(result)
     }
 
@@ -662,6 +669,10 @@ impl Configurator {
         result.metadata = Some(
             self.get_result_metadata(Operation::Test)
         );
+        self.process_output()?;
+        if !self.context.outputs.is_empty() {
+            result.outputs = Some(self.context.outputs.clone());
+        }
         Ok(result)
     }
 
@@ -724,6 +735,10 @@ impl Configurator {
         }
 
         result.result = Some(conf);
+        self.process_output()?;
+        if !self.context.outputs.is_empty() {
+            result.outputs = Some(self.context.outputs.clone());
+        }
         Ok(result)
     }
 
@@ -738,6 +753,46 @@ impl Configurator {
         Ok(false)
     }
 
+    pub fn process_output(&mut self) -> Result<(), DscError> {
+        if self.config.outputs.is_none() || self.context.execution_type == ExecutionKind::WhatIf {
+            return Ok(());
+        }
+        if let Some(outputs) = &self.config.outputs {
+            for (name, output) in outputs {
+                if let Some(condition) = &output.condition {
+                    let condition_result = self.statement_parser.parse_and_execute(condition, &self.context)?;
+                    if condition_result != Value::Bool(true) {
+                        info!("{}", t!("configure.mod.skippingOutput", name = name));
+                        continue;
+                    }
+                }
+
+                match &output.value_or_copy {
+                    ValueOrCopy::Value(value) => {
+                        let value_result = self.statement_parser.parse_and_execute(&value, &self.context)?;
+                        if output.r#type == DataType::SecureString || output.r#type == DataType::SecureObject {
+                            warn!("{}", t!("configure.mod.secureOutputSkipped", name = name));
+                            continue;
+                        }
+                        if value_result.is_string() && output.r#type != DataType::String ||
+                            value_result.is_i64() && output.r#type != DataType::Int ||
+                            value_result.is_boolean() && output.r#type != DataType::Bool ||
+                            value_result.is_array() && output.r#type != DataType::Array ||
+                            value_result.is_object() && output.r#type != DataType::Object {
+                            return Err(DscError::Validation(t!("configure.mod.outputTypeNotMatch", name = name, expected_type = output.r#type).to_string()));
+                        }
+                        self.context.outputs.insert(name.clone(), value_result);
+                    },
+                    _ => {
+                        warn!("{}", t!("configure.mod.copyNotSupported", name = name));
+                        continue;
+                    }
+                }
+            }
+        }
+        Ok(())
+    }
+
     /// Set the mounted path for the configuration.
     ///
     /// # Arguments
@@ -779,7 +834,7 @@ impl Configurator {
         if let Some(parameters_input) = parameters_input {
             trace!("parameters_input: {parameters_input}");
             let input_parameters: HashMap<String, Value> = serde_json::from_value::<Input>(parameters_input.clone())?.parameters;
-            
+
             for (name, value) in input_parameters {
                 if let Some(constraint) = parameters.get(&name) {
                     debug!("Validating parameter '{name}'");
@@ -818,7 +873,7 @@ impl Configurator {
 
         while !unresolved_parameters.is_empty() {
             let mut resolved_in_this_pass = Vec::new();
-            
+
             for (name, parameter) in &unresolved_parameters {
                 debug!("{}", t!("configure.mod.processingParameter", name = name));
                 if let Some(default_value) = &parameter.default_value {

Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,7 @@`
`3`	`3`
`4`	`4`	`use schemars::JsonSchema;`
`5`	`5`	`use serde::{Deserialize, Serialize};`
	`6`	`+use serde_json::{Map, Value};`
`6`	`7`	`use crate::dscresources::invoke_result::{GetResult, SetResult, TestResult};`
`7`	`8`	`use crate::configure::config_doc::{Configuration, Metadata};`
`8`	`9`
`@@ -54,6 +55,8 @@ pub struct ConfigurationGetResult {`
`54`	`55`	`pub messages: Vec<ResourceMessage>,`
`55`	`56`	`#[serde(rename = "hadErrors")]`
`56`	`57`	`pub had_errors: bool,`
	`58`	`+ #[serde(skip_serializing_if = "Option::is_none")]`
	`59`	`+ pub outputs: Option<Map<String, Value>>,`
`57`	`60`	`}`
`58`	`61`
`59`	`62`	`impl ConfigurationGetResult {`
`@@ -64,6 +67,7 @@ impl ConfigurationGetResult {`
`64`	`67`	`results: Vec::new(),`
`65`	`68`	`messages: Vec::new(),`
`66`	`69`	`had_errors: false,`
	`70`	`+ outputs: None,`
`67`	`71`	`}`
`68`	`72`	`}`
`69`	`73`	`}`
`@@ -85,6 +89,7 @@ impl From<ConfigurationTestResult> for ConfigurationGetResult {`
`85`	`89`	`results,`
`86`	`90`	`messages: test_result.messages,`
`87`	`91`	`had_errors: test_result.had_errors,`
	`92`	`+ outputs: test_result.outputs,`
`88`	`93`	`}`
`89`	`94`	`}`
`90`	`95`	`}`
`@@ -140,6 +145,8 @@ pub struct ConfigurationSetResult {`
`140`	`145`	`pub messages: Vec<ResourceMessage>,`
`141`	`146`	`#[serde(rename = "hadErrors")]`
`142`	`147`	`pub had_errors: bool,`
	`148`	`+ #[serde(skip_serializing_if = "Option::is_none")]`
	`149`	`+ pub outputs: Option<Map<String, Value>>,`
`143`	`150`	`}`
`144`	`151`
`145`	`152`	`impl ConfigurationSetResult {`
`@@ -150,6 +157,7 @@ impl ConfigurationSetResult {`
`150`	`157`	`results: Vec::new(),`
`151`	`158`	`messages: Vec::new(),`
`152`	`159`	`had_errors: false,`
	`160`	`+ outputs: None,`
`153`	`161`	`}`
`154`	`162`	`}`
`155`	`163`	`}`
`@@ -200,6 +208,8 @@ pub struct ConfigurationTestResult {`
`200`	`208`	`pub messages: Vec<ResourceMessage>,`
`201`	`209`	`#[serde(rename = "hadErrors")]`
`202`	`210`	`pub had_errors: bool,`
	`211`	`+ #[serde(skip_serializing_if = "Option::is_none")]`
	`212`	`+ pub outputs: Option<Map<String, Value>>,`
`203`	`213`	`}`
`204`	`214`
`205`	`215`	`impl ConfigurationTestResult {`
`@@ -210,6 +220,7 @@ impl ConfigurationTestResult {`
`210`	`220`	`results: Vec::new(),`
`211`	`221`	`messages: Vec::new(),`
`212`	`222`	`had_errors: false,`
	`223`	`+ outputs: None,`
`213`	`224`	`}`
`214`	`225`	`}`
`215`	`226`	`}`
`@@ -228,6 +239,8 @@ pub struct ConfigurationExportResult {`
`228`	`239`	`pub messages: Vec<ResourceMessage>,`
`229`	`240`	`#[serde(rename = "hadErrors")]`
`230`	`241`	`pub had_errors: bool,`
	`242`	`+ #[serde(skip_serializing_if = "Option::is_none")]`
	`243`	`+ pub outputs: Option<Map<String, Value>>,`
`231`	`244`	`}`
`232`	`245`
`233`	`246`	`impl ConfigurationExportResult {`
`@@ -238,6 +251,7 @@ impl ConfigurationExportResult {`
`238`	`251`	`result: None,`
`239`	`252`	`messages: Vec::new(),`
`240`	`253`	`had_errors: false,`
	`254`	`+ outputs: None,`
`241`	`255`	`}`
`242`	`256`	`}`
`243`	`257`	`}`
Original file line number	Diff line number	Diff line change
`@@ -36,6 +36,7 @@ pub struct Context {`
`36`	`36`	`pub system_root: PathBuf,`
`37`	`37`	`pub user_functions: HashMap<String, UserFunctionDefinition>,`
`38`	`38`	`pub variables: Map<String, Value>,`
	`39`	`+ pub outputs: Map<String, Value>,`
`39`	`40`	`}`
`40`	`41`
`41`	`42`	`impl Context {`
`@@ -61,6 +62,8 @@ impl Context {`
`61`	`62`	`system_root: get_default_os_system_root(),`
`62`	`63`	`user_functions: HashMap::new(),`
`63`	`64`	`variables: Map::new(),`
	`65`	`+ restart_required: None,`
	`66`	`+ outputs: Map::new(),`
`64`	`67`	`}`
`65`	`68`	`}`
`66`	`69`	`}`