Bugfix for comparing file path name to determine exact match #1817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Can we add a test? |
|
Looks good, agree with adding the test if it's feasible. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I think it's possible this PR fixes bug #1837. Making a note for one of us to come back to this :) |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
adityapatwardhan
approved these changes
Aug 26, 2025
14 tasks
This was referenced Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Utils.cs has GetMetadataFilesFromPath() that is used by the PublishPSResource and LocalServerApiCalls classes.
In that method we find files which match the package name such as the .psd1, .ps1, .nuspec files. It catches file names that match
packageName*but that includes files that should not be matched. For example, the Az.KeyVault package has 2 .psd1 files:AzKeyVault.psd1andAz.KeyVault.Extension.psd1and the latter was getting considered as a valid match. This PR fixes that. Thestring.Compare()method is already correctly determining if the filename is a correct match so the code to store that file path as a path of interest should happen in that condition set bystring.Compare()PR Context
Resolves Azure/azure-powershell#27535
Resolves #1837 #1762
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.