From c722746b480ecca2b51038350e2afc1d39cdd591 Mon Sep 17 00:00:00 2001 From: Christoph Bergmeister Date: Fri, 4 Apr 2025 21:14:08 +0100 Subject: [PATCH 1/3] Exclude PSNativeCommandArgumentPassing variable --- Engine/SpecialVars.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Engine/SpecialVars.cs b/Engine/SpecialVars.cs index a8be18b92..82639eda9 100644 --- a/Engine/SpecialVars.cs +++ b/Engine/SpecialVars.cs @@ -160,6 +160,7 @@ internal enum PreferenceVariable internal const string PSEmailServer = "PSEmailServer"; internal const string PSDefaultParameterValues = "PSDefaultParameterValues"; internal const string PSModuleAutoLoadingPreference = "PSModuleAutoLoadingPreference"; + internal const string PSNativeCommandArgumentPassing = "PSNativeCommandArgumentPassing"; internal const string pwd = "PWD"; internal const string Null = "null"; internal const string True = "true"; @@ -182,6 +183,7 @@ internal enum PreferenceVariable PSEmailServer, PSDefaultParameterValues, PSModuleAutoLoadingPreference, + PSNativeCommandArgumentPassing. pwd, Null, True, From 7912b03cc5cff155776c24ab6558e233a783dd19 Mon Sep 17 00:00:00 2001 From: Christoph Bergmeister Date: Fri, 4 Apr 2025 21:16:18 +0100 Subject: [PATCH 2/3] Update UseDeclaredVarsMoreThanAssignments.tests.ps1 --- Tests/Rules/UseDeclaredVarsMoreThanAssignments.tests.ps1 | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Tests/Rules/UseDeclaredVarsMoreThanAssignments.tests.ps1 b/Tests/Rules/UseDeclaredVarsMoreThanAssignments.tests.ps1 index 592aecc91..113563796 100644 --- a/Tests/Rules/UseDeclaredVarsMoreThanAssignments.tests.ps1 +++ b/Tests/Rules/UseDeclaredVarsMoreThanAssignments.tests.ps1 @@ -58,6 +58,12 @@ function MyFunc2() { Should -Be 0 } + It "does not flag `$PSNativeCommandArgumentPassing variable" { + Invoke-ScriptAnalyzer -ScriptDefinition '$PSNativeCommandArgumentPassing=None' -IncludeRule $violationName | ` + Get-Count | ` + Should -Be 0 + } + It "does not flag global variable" { Invoke-ScriptAnalyzer -ScriptDefinition '$global:x=$null' -IncludeRule $violationName | ` Get-Count | ` From 492e0f600e7ffb76c183a2b927f0a1c04d574a79 Mon Sep 17 00:00:00 2001 From: Christoph Bergmeister Date: Fri, 4 Apr 2025 21:16:45 +0100 Subject: [PATCH 3/3] Add missing comma in SpecialVars.cs --- Engine/SpecialVars.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Engine/SpecialVars.cs b/Engine/SpecialVars.cs index 82639eda9..3416a5ad2 100644 --- a/Engine/SpecialVars.cs +++ b/Engine/SpecialVars.cs @@ -183,7 +183,7 @@ internal enum PreferenceVariable PSEmailServer, PSDefaultParameterValues, PSModuleAutoLoadingPreference, - PSNativeCommandArgumentPassing. + PSNativeCommandArgumentPassing, pwd, Null, True,