Use --follow-symlinks in VSCE package command and simplify build logic
#5212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: andyleejordan <[email protected]>
Co-authored-by: andyleejordan <[email protected]>
Copilot
AI
changed the title
Copilot finished work on behalf of
andyleejordan
June 11, 2025 19:48
andyleejordan
requested changes
Jun 11, 2025
|
Hey @copilot iterate based on my review. |
I don't have access to the specific review comments. Could you please provide details on what aspects you'd like me to iterate on? The current implementation adds Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot finished work on behalf of
andyleejordan
June 11, 2025 20:54
|
Hey @copilot iterate based on my review again please. |
…ify build logic, add assertion Co-authored-by: andyleejordan <[email protected]>
I've addressed your review feedback in commit 9962d48:
The changes reduce the build script by 17 lines while maintaining the same functionality with better assertions. |
Copilot
AI
changed the title
Copilot finished work on behalf of
andyleejordan
September 4, 2025 20:30
andyleejordan
requested changes
Sep 4, 2025
andyleejordan
changed the title
--follow-symlinks in VSCE package command
Co-authored-by: andyleejordan <[email protected]>
Copilot
AI
changed the title
--follow-symlinks in VSCE package command
Copilot finished work on behalf of
andyleejordan
September 4, 2025 20:40
andyleejordan
approved these changes
Sep 4, 2025
andyleejordan
changed the title
--follow-symlinks in VSCE package command and simplify build logic
There was a problem hiding this comment.
Pull Request Overview
This PR implements support for the --follow-symlinks flag in VSCE to eliminate unnecessary file copying during builds and significantly simplifies the build logic for PowerShell Editor Services (PSES) modules.
- Added
--follow-symlinksflag to the VSCE package command to handle symbolic links natively - Unified symlink handling logic for both Debug and Release configurations
- Simplified PSES building to consistently use
Invoke-Buildand removed conditional copying logic
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Added --follow-symlinks flag to the VSCE package command |
| vscode-powershell.build.ps1 | Simplified build logic by removing Debug/Release switch statement and file copying operations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
SydneyhSmith
approved these changes
Sep 4, 2025
|
Even having opted out of the broken enterprise ruleset I still couldn't get this to merge without a bypass 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for the new
--follow-symlinksflag in VSCE to eliminate the unnecessary copying of PowerShell Editor Services (PSES) modules during builds, as requested in #5169.What Changed
Package.json Scripts:
--follow-symlinksflag to thevsce packagecommand only (not publish)Build Script Simplification:
Invoke-Buildfor consistencyBenefits
Before/After Comparison
Before: Build script had separate logic for Debug (symlinks + always build) and Release (copies + conditional build):
After: Unified logic with native VSCE symlink support:
This change leverages the symlink following support added to VSCE in October 2024 (microsoft/vscode-vsce@51e122a).
Fixes #5169.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.