fixing up email string array splitting

Signed-off-by: Neil South <[email protected]>

Author: neildsouth

src/WorkflowManager/WorkflowManager/Validators/WorkflowValidator.cs

@@ -481,7 +481,7 @@ private void ValidateEmailTask(TaskObject currentTask)
             if (emailsSpecified)
             {
                 var emails = currentTask.Args[RecipientEmails] ?? string.Empty;
-                var formattedEmails = emails.Split(',').Where(e => !string.IsNullOrWhiteSpace(e.Trim()));
+                var formattedEmails = emails.Split(',', StringSplitOptions.TrimEntries | StringSplitOptions.RemoveEmptyEntries);
 
                 if (!formattedEmails.Any())
                 {
@@ -522,7 +522,7 @@ private void ValidateEmailTask(TaskObject currentTask)
             if (rolesSpecified)
             {
                 var roles = currentTask.Args[RecipientRoles] ?? string.Empty;
-                var formattedRoles = roles.Split(',').Where(r => !string.IsNullOrWhiteSpace(r.Trim()));
+                var formattedRoles = roles.Split(',', StringSplitOptions.TrimEntries | StringSplitOptions.RemoveEmptyEntries);
 
                 if (!formattedRoles.Any())
                 {
@@ -538,15 +538,15 @@ private void ValidateEmailTask(TaskObject currentTask)
             }
 
             var metadataValues = currentTask.Args[MetadataValues] ?? string.Empty;
-            var formattedMetadataValues = metadataValues.Split(',').Where(m => !string.IsNullOrWhiteSpace(m.Trim()));
+            var formattedMetadataValues = metadataValues.Split(',', StringSplitOptions.TrimEntries | StringSplitOptions.RemoveEmptyEntries);
 
             if (!formattedMetadataValues.Any())
             {
                 Errors.Add($"Argument '{MetadataValues}' for task {currentTask.Id} must be a comma seperated list of DICOM metadata tag names.");
                 return;
             }
 
-            var disallowedTags = _options.Value.DicomTagsDisallowed.Split(',').Select(t => t.Trim());
+            var disallowedTags = _options.Value.DicomTagsDisallowed.Split(',', StringSplitOptions.TrimEntries | StringSplitOptions.RemoveEmptyEntries);
             var intersect = formattedMetadataValues.Intersect(disallowedTags);
 
             if (intersect.Any())