AC-1989 validate priority

Signed-off-by: Neil South <[email protected]>

Author: neildsouth

src/WorkflowManager/WorkflowManager/Validators/WorkflowValidator.cs

@@ -41,6 +41,7 @@ public class WorkflowValidator
         public static readonly string Separator = ";";
         private const string Comma = ", ";
         private readonly ILogger<WorkflowValidator> _logger;
+        public static readonly string TaskPriorityClassName = "priority";
 
         /// <summary>
         /// Initializes a new instance of the <see cref="WorkflowValidator"/> class.
@@ -335,6 +336,18 @@ private void ValidateArgoTask(TaskObject currentTask)
             {
                 Errors.Add($"Task: '{currentTask.Id}' workflow_template_name must be specified{Comma}this corresponds to an Argo template name.");
             }
+
+            if (currentTask.Args.ContainsKey(TaskPriorityClassName))
+            {
+                switch (currentTask.Args[TaskPriorityClassName].ToLower())
+                {
+                    case "high" or "standard" or "low":
+                        break;
+                    default:
+                        Errors.Add($"Task: '{currentTask.Id}' TaskPriorityClassName must be one of \"high\"{Comma} \"standard\" or \"low\"");
+                        break;
+                }
+            }
         }
 
         private void ValidateClinicalReviewTask(TaskObject[] tasks, TaskObject currentTask)

tests/UnitTests/WorkflowManager.Tests/Validators/WorkflowValidatorTests.cs

@@ -17,6 +17,7 @@
 using System;
 using System.Security.Cryptography.Xml;
 using System.Threading.Tasks;
+using Amazon.Runtime.Internal.Transform;
 using Microsoft.Extensions.Logging;
 using Monai.Deploy.WorkflowManager.Common.Interfaces;
 using Monai.Deploy.WorkflowManager.Contracts.Models;
@@ -535,5 +536,97 @@ public async Task ValidateWorkflow_ValidateWorkflow_ReturnsNoErrors()
                 Assert.True(errors.Count == 0);
             }
         }
+
+        [Fact]
+        public async Task ValidateWorkflow_Incorrect_podPriorityClassName_ReturnsErrors()
+        {
+            var workflow = new Workflow
+            {
+                Name = "Workflowname1",
+                Description = "Workflowdesc1",
+                Version = "1",
+                InformaticsGateway = new InformaticsGateway
+                {
+                    AeTitle = "aetitle",
+                    ExportDestinations = new string[] { "oneDestination", "twoDestination", "threeDestination" }
+                },
+                Tasks = new TaskObject[]
+                {
+                    new TaskObject
+                    {
+                        Args = new System.Collections.Generic.Dictionary<string, string>{
+                            { "priority" ,"god" },
+                            { "workflow_template_name" ,"spot"}
+                        },
+                        Id = "rootTask",
+                        Type = "argo",
+                        Description = "TestDesc",
+                        Artifacts = new ArtifactMap
+                        {
+                            Input = new Artifact[]{
+                                new Artifact
+                                {
+                                    Name = "non_unique_artifact",
+                                    Value = "Example Value"
+                                }
+                            }
+                        }
+                    },
+                }
+            };
+
+            _workflowService.Setup(w => w.GetByNameAsync(It.IsAny<string>()))
+                .ReturnsAsync(null, TimeSpan.FromSeconds(.1));
+
+            var errors = await _workflowValidator.ValidateWorkflow(workflow);
+
+            Assert.Single(errors);
+        }
+
+        [Fact]
+        public async Task ValidateWorkflow_correct_podPriorityClassName_ReturnsNoErrors()
+        {
+            var workflow = new Workflow
+            {
+                Name = "Workflowname1",
+                Description = "Workflowdesc1",
+                Version = "1",
+                InformaticsGateway = new InformaticsGateway
+                {
+                    AeTitle = "aetitle",
+                    ExportDestinations = new string[] { "oneDestination", "twoDestination", "threeDestination" }
+                },
+                Tasks = new TaskObject[]
+                {
+                    new TaskObject
+                    {
+                        Args = new System.Collections.Generic.Dictionary<string, string>{
+                            { "priority" ,"high" },
+                            { "workflow_template_name" ,"spot"}
+                        },
+                        Id = "rootTask",
+                        Type = "argo",
+                        Description = "TestDesc",
+                        Artifacts = new ArtifactMap
+                        {
+                            Input = new Artifact[]{
+                                new Artifact
+                                {
+                                    Name = "non_unique_artifact",
+                                    Value = "Example Value"
+                                }
+                            }
+                        }
+                    },
+                }
+            };
+
+            _workflowService.Setup(w => w.GetByNameAsync(It.IsAny<string>()))
+                .ReturnsAsync(null, TimeSpan.FromSeconds(.1));
+
+            var errors = await _workflowValidator.ValidateWorkflow(workflow);
+
+            Assert.Empty(errors);
+        }
     }
 }