AutoencoderKlMaisi

[shengzhang90]

Hi, @Can-Zhao

Why is it "if self.dim_split <= 1 and self.num_splits <= 1:" in the code of line 235, shouldn't it be "if self.dim_split < 1 and self.num_splits <= 1:" Since your setting in the "configs/config_maisi3d-rflow.json" is that dim_split = 1.

https://github.com/Project-MONAI/MONAI/blob/dev/monai/apps/generation/maisi/networks/autoencoderkl_maisi.py

Thanks a lot.

Best wishes

[Can-Zhao]

self.dim_split =0 and self.dim_split = 1 means no split. They are the same

[shengzhang90]

Hi, @dongyang0122

The default value of "dim_split" in the file of "https://github.com/Project-MONAI/tutorials/blob/main/generation/maisi/configs/config_maisi3d-rflow.json" is wrong? Should it be 2, 3, 4.

Thanks a lot.

[Can-Zhao]

Oh I see your point. You were talking about "dim_split”. The code https://github.com/Project-MONAI/MONAI/blob/dev/monai/apps/generation/maisi/networks/autoencoderkl_maisi.py needs to be changed.
Thank you a lot!

[shengzhang90]

Maybe the code in file: https://github.com/Project-MONAI/MONAI/blob/dev/monai/apps/generation/maisi/networks/autoencoderkl_maisi.py is not wrong, but the default value of "dim_split" in config file of "configs/config_maisi3d-rflow.json" should be changed to 2, 3, 4?

[Can-Zhao]

It seems to be "dim_split" should be 0,1,2

[Can-Zhao]

self.dim_split =0 and self.dim_split = 1 means no split. They are the same

I thought you were talking about "num_splits"