-
Notifications
You must be signed in to change notification settings - Fork 893
fix: Replace macro use in ordered_float tests #5602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The tests make use of the py_run macro which is only available with the macros feature enabled.
2804c4b to
662018b
Compare
|
Probably too late, I just read through the related comments on #5344 and I still think this is ok as a stand-alone change. The tests rely on the macro so requiring it makes some sense. Would it be better to replace the macro uses so the tests run with no other features enabled or is it still clearer to use the shorthand version? |
Replace the py_run macro with a local function offering a simplified but sufficient functionality
|
Replacing the macro didn't look too bad so is possibly the better approach so the tests aren't skipped unexpectedly. |
|
Thanks very much for this! Doing this got me experimenting, IIRC we gated Maybe we can simplify and do something like #5608, and then always allow |
The tests make use of the py_run macro which is only available with the
macros feature enabled.
While the py_run macro supports a wider range of requirements, the way
it is used in these tests is straightforward enough that it can be
replaced with a local function to prevent the macros feature needing to
be enabled.