chore: review comments

maiieul · maiieul · commit a772f636330b · 2025-10-15T07:32:35.000+02:00
diff --git a/starters/apps/library/src/components/counter/counter.tsx b/starters/apps/library/src/components/counter/counter.tsx
@@ -1,6 +1,6 @@
-import { component$, PropsOf, useSignal } from "@qwik.dev/core";
+import { component$, useSignal } from "@qwik.dev/core";
 
-export const Counter = component$<PropsOf<"div">>(() => {
+export const Counter = component$(() => {
   const count = useSignal(0);
 
   return (
diff --git a/starters/apps/library/src/components/logo/logo.tsx b/starters/apps/library/src/components/logo/logo.tsx
@@ -1,6 +1,6 @@
-import { component$, PropsOf } from "@qwik.dev/core";
+import { component$ } from "@qwik.dev/core";
 
-export const Logo = component$<PropsOf<"div">>(() => {
+export const Logo = component$(() => {
   return (
     <div>
       <a href="https://qwik.dev/">
diff --git a/starters/apps/library/src/entry.dev.tsx b/starters/apps/library/src/entry.dev.tsx
diff --git a/starters/apps/library/src/entry.ssr.tsx b/starters/apps/library/src/entry.ssr.tsx
@@ -1,21 +1,31 @@
 /**
  * WHAT IS THIS FILE?
  *
- * SSR entry point, in all cases the application is rendered outside the browser, this
- * entry point will be the common one.
- *
- * - Server (express, cloudflare...)
- * - npm run start
- * - npm run preview
- * - npm run build
+ * SSR renderer function, used by Qwik Router.
  *
+ * Note that this is the only place the Qwik renderer is called.
+ * On the client, containers resume and do not call render.
  */
-import {
-  renderToStream,
-  type RenderToStreamOptions,
-} from "@qwik.dev/core/server";
+import { createRenderer } from "@qwik.dev/router";
 import Root from "./root";
 
-export default function (opts: RenderToStreamOptions) {
-  return renderToStream(<Root />, opts);
-}
+export default createRenderer((opts) => {
+  return {
+    jsx: <Root />,
+    options: {
+      ...opts,
+      // Use container attributes to set attributes on the html tag.
+      containerAttributes: {
+        lang: "en-us",
+        ...opts.containerAttributes,
+      },
+      serverData: {
+        ...opts.serverData,
+        // These are the default values for the document head and are overridden by the `head` exports
+        // documentHead: {
+        //   title: "My App",
+        // },
+      },
+    },
+  };
+});
diff --git a/starters/apps/library/src/root.tsx b/starters/apps/library/src/root.tsx
@@ -1,15 +1,35 @@
-import { QwikRouterProvider, RouterOutlet } from "@qwik.dev/router";
+import { component$ } from "@qwik.dev/core";
+import {
+  DocumentHeadTags,
+  RouterOutlet,
+  useLocation,
+  useQwikRouter,
+} from "@qwik.dev/router";
+
+import "./global.css";
+
+export default component$(() => {
+  useQwikRouter();
+  const { url } = useLocation();
+
+  /**
+   * This is the root of a QwikRouter site. It contains the document's `<head>` and `<body>`. You can adjust them as you see fit.
+   */
 
-export default () => {
   return (
-    <QwikRouterProvider>
+    <>
       <head>
         <meta charset="utf-8" />
-        <title>Qwik Blank App</title>
+        <meta name="viewport" content="width=device-width, initial-scale=1.0" />
+        <link rel="icon" type="image/svg+xml" href="/favicon.svg" />
+
+        <DocumentHeadTags />
+
+        <link rel="canonical" href={url.href} />
       </head>
       <body>
         <RouterOutlet />
       </body>
-    </QwikRouterProvider>
+    </>
   );
-};
+});
diff --git a/starters/apps/library/src/routes/index.tsx b/starters/apps/library/src/routes/index.tsx
@@ -7,10 +7,10 @@ export default component$(() => {
     <>
       <h1>Qwik Library Starter</h1>
       <p>
-        This is a Qwik library starter. Make your components and export them
-        from `src/index.ts`. This playground app will not be bundled with your
-        library. You can use the Router like a normal Qwik app with the Qwik
-        Router.
+        This is a playground meant for testing your library. Make your
+        components and export them from `src/index.ts`. This playground app will
+        not be bundled with your library. You can use the Router like a normal
+        Qwik app with the Qwik Router.
       </p>
       <Logo />
       <Counter />
diff --git a/starters/apps/library/tsconfig.json b/starters/apps/library/tsconfig.json
@@ -9,7 +9,6 @@
     "strict": true,
     "declaration": true,
     "declarationDir": "lib",
-    "rootDir": "src",
     "resolveJsonModule": true,
     "moduleResolution": "Bundler",
     "esModuleInterop": true,
