Address code review comments.

Author: mirza-halilcevic

mlir/lib/Dialect/Rock/Tuning/GridwiseGemmParams.cpp

@@ -129,7 +129,17 @@ class ParamLookupTable {
     return relatives;
   }
 
-  // Find the lexicographically closest relative
+  // Finds the lexicographically closest architecture variant when the exact
+  // target key is not found in the lookup table.
+  //
+  // A "relative" entry must have:
+  // - Same suffix (operation + data type, e.g., "_gemm_f16")
+  // - Same architecture prefix (e.g., "gfx9" for gfx908, gfx90a, gfx942)
+  //
+  // Example: If target "gfx1151_gemm_f16" is missing but "gfx1101_gemm_f16"
+  // and "gfx1201_gemm_f16" exist, this picks the lexicographically closest one
+  // (gfx1101_gemm_f16). This enables graceful fallback between similar GPU
+  // architectures.
   static std::string findFallback(const std::string &target) {
     const auto relatives = getRelatives(target);
     if (relatives.empty())
@@ -319,8 +329,8 @@ PopulateParams::populateDerived(const InitParamsNonAccel &params) {
   LogicalResult res = calculateBlockGemmPerformanceParameters(params);
 
   if (failed(res)) {
-    LLVM_DEBUG(llvm::dbgs() << "Incoherent blockGemm tuning parameter "
-                            << " size.\n");
+    LLVM_DEBUG(llvm::dbgs()
+               << "Incoherent blockGemm tuning parameter " << " size.\n");
     return failure();
   }
 

mlir/utils/performance/analysis/quickTuningGen.py

@@ -45,7 +45,7 @@ def replace_section(self, file_path, ifdef_guard, begin_marker, end_marker, new_
         with open(file_path, 'r') as file:
             content = file.read()
 
-        pattern = re.compile(f'{begin_marker}.*?{end_marker}', re.DOTALL)
+        pattern = re.compile(f'{re.escape(begin_marker)}.*?{re.escape(end_marker)}', re.DOTALL)
         if not pattern.search(content):
             ifdef_match = re.search(rf'{re.escape(ifdef_guard)}(.*?)(?=#endif)', content, re.DOTALL)
             if (ifdef_match):
@@ -55,8 +55,8 @@ def replace_section(self, file_path, ifdef_guard, begin_marker, end_marker, new_
             else:
                 raise ValueError(f"Cannot find {ifdef_guard} in {file_path}")
 
-        replacment = f'{begin_marker}\n{new_content}\n{end_marker}'
-        content = pattern.sub(replacment, content)
+        replacement = f'{begin_marker}\n{new_content}\n{end_marker}'
+        content = pattern.sub(replacement, content)
 
         with open(file_path, 'w') as file:
             file.write(content)
@@ -68,7 +68,7 @@ def update_lookup_table(self, file_path, ifdef_guard, mapping):
         with open(file_path, 'r') as file:
             content = file.read()
 
-        pattern = re.compile(f'{mapping}', re.DOTALL)
+        pattern = re.compile(f'{re.escape(mapping)}', re.DOTALL)
         if not pattern.search(content):
             ifdef_match = re.search(rf'{re.escape(ifdef_guard)}(.*?)(?=#endif)', content, re.DOTALL)
             if (ifdef_match):
@@ -373,7 +373,7 @@ def print_results(result):
 def main(args=None):
     """
     usage: quickTunerGen.py [-h] --input-dir INPUT_DIR --op {gemm,conv} [--th TH] --arch ARCH [--update] [--no-splitk]
-    usage exsample: python3 quickTuningGen.py --input-dir tunedData --op conv --arch gfx90a --update --no-splitk
+    usage example: python3 quickTuningGen.py --input-dir tunedData --op conv --arch gfx90a --update --no-splitk
     """
     if args is None:
         args = sys.argv[1:]
@@ -393,7 +393,7 @@ def main(args=None):
     parser.add_argument('--no-splitk',
                         default=False,
                         action='store_true',
-                        help='Removing the Split-K factor from the generated list')
+                        help='Remove the Split-K factor from the generated list')
 
     pargs = parser.parse_args()