test: Enhance test coverage for the user application

RandomProgramm3r · RandomProgramm3r · commit 0df06495820e · 2025-07-26T16:14:53.000+03:00
This commit introduces a comprehensive set of tests for the `user` application, significantly improving its test coverage and  ensuring the reliability of its components.

 Key additions include:
- **Authentication:** Added tests for `CustomJWTAuthentication` to validate token handling, user type verification, and error  scenarios like mismatched token versions or missing user IDs.
 - **Models:** Created new tests for `UserManager` and `User` model behaviors, including `__str__` representations and superuser  creation. Added tests for related models like `PromoLike`, `PromoComment`, and `PromoActivationHistory`.
- **Services:** Implemented tests for `PromoActivationService` to cover edge cases in targeting logic and race conditions where a promo might be deleted during activation.
- **Anti-Fraud:** Added a test to ensure `AntiFraudService` correctly handles missing cache timeout values.
 - **Profile Operations:** Expanded tests for the user profile endpoint to cover partial updates (`PATCH`) of email and the `other` data field, including validation against existing emails.
diff --git a/promo_code/user/tests/auth/test_authentication.py b/promo_code/user/tests/auth/test_authentication.py
@@ -1,5 +1,12 @@
+import uuid
+
+import django.test
 import rest_framework.status
+import rest_framework_simplejwt.exceptions
+import rest_framework_simplejwt.tokens
 
+import business.models
+import user.authentication
 import user.models
 import user.tests.auth.base
 
@@ -27,3 +34,90 @@ def test_signin_success(self):
             response.status_code,
             rest_framework.status.HTTP_200_OK,
         )
+
+
+class CustomJWTAuthenticationTest(django.test.TestCase):
+    def setUp(self):
+        self.factory = django.test.RequestFactory()
+        self.authenticator = user.authentication.CustomJWTAuthentication()
+        self.user = user.models.User.objects.create(
+            name='testuser_uuid',
+            token_version=1,
+        )
+        self.company = business.models.Company.objects.create(
+            name='testcompany_uuid',
+            token_version=1,
+        )
+
+    def _get_token_with_payload(self, payload):
+        token = rest_framework_simplejwt.tokens.AccessToken()
+        token.payload.update(payload)
+        return str(token)
+
+    def test_authenticate_invalid_user_type(self):
+        payload = {
+            'user_type': 'admin',
+            'user_id': str(self.user.id),
+            'token_version': self.user.token_version,
+        }
+        token = self._get_token_with_payload(payload)
+        request = self.factory.get('/api/test/')
+        request.META['HTTP_AUTHORIZATION'] = f'Bearer {token}'
+        with self.assertRaisesMessage(
+            rest_framework_simplejwt.exceptions.AuthenticationFailed,
+            'Invalid user type',
+        ):
+            self.authenticator.authenticate(request)
+
+    def test_authenticate_missing_id_in_token(self):
+        payload = {
+            'user_type': 'user',
+            'token_version': self.user.token_version,
+        }
+        token = self._get_token_with_payload(payload)
+        request = self.factory.get('/api/test/')
+        request.META['HTTP_AUTHORIZATION'] = f'Bearer {token}'
+        with self.assertRaisesMessage(
+            rest_framework_simplejwt.exceptions.AuthenticationFailed,
+            'Missing user_id in token',
+        ):
+            self.authenticator.authenticate(request)
+
+    def test_authenticate_mismatched_token_version(self):
+        payload = {
+            'user_type': 'user',
+            'user_id': str(self.user.id),
+            'token_version': 1,
+        }
+        token = self._get_token_with_payload(payload)
+        self.user.token_version = 2
+        self.user.save()
+        request = self.factory.get('/api/test/')
+        request.META['HTTP_AUTHORIZATION'] = f'Bearer {token}'
+        with self.assertRaisesMessage(
+            rest_framework_simplejwt.exceptions.AuthenticationFailed,
+            'Token invalid',
+        ):
+            self.authenticator.authenticate(request)
+
+    def test_authenticate_user_or_company_not_found(self):
+        non_existent_uuid = str(uuid.uuid4())
+        payload = {
+            'user_type': 'user',
+            'user_id': non_existent_uuid,
+            'token_version': 1,
+        }
+        token = self._get_token_with_payload(payload)
+        request = self.factory.get('/api/test/')
+        request.META['HTTP_AUTHORIZATION'] = f'Bearer {token}'
+        with self.assertRaisesMessage(
+            rest_framework_simplejwt.exceptions.AuthenticationFailed,
+            'User or Company not found',
+        ):
+            self.authenticator.authenticate(request)
+
+    def test_authenticate_raw_token_none(self):
+        request = self.factory.get('/api/test/')
+        request.META['HTTP_AUTHORIZATION'] = 'Token abcdefg'
+        result = self.authenticator.authenticate(request)
+        self.assertIsNone(result)
diff --git a/promo_code/user/tests/user/operations/test_profile.py b/promo_code/user/tests/user/operations/test_profile.py
@@ -145,3 +145,59 @@ def test_auth_sign_in_new_password_succeeds(self):
             response.status_code,
             rest_framework.status.HTTP_200_OK,
         )
+
+    def test_patch_profile_update_other(self):
+        new_other = {'age': 30, 'country': 'ca'}
+        response = self.client.patch(
+            self.user_profile_url,
+            {'other': new_other},
+            format='json',
+        )
+
+        self.assertEqual(
+            response.status_code,
+            rest_framework.status.HTTP_200_OK,
+        )
+
+        self.assertEqual(
+            response.data.get('other'),
+            new_other,
+        )
+
+        get_resp = self.client.get(self.user_profile_url, format='json')
+        self.assertEqual(
+            get_resp.status_code,
+            rest_framework.status.HTTP_200_OK,
+        )
+        self.assertEqual(
+            get_resp.data.get('other'),
+            new_other,
+        )
+
+    def test_patch_profile_update_mail(self):
+        new_email = 'new_creator@apple.com'
+        response = self.client.patch(
+            self.user_profile_url,
+            {'email': new_email},
+            format='json',
+        )
+
+        self.assertEqual(
+            response.status_code,
+            rest_framework.status.HTTP_200_OK,
+        )
+
+        self.assertEqual(
+            response.data.get('email'),
+            new_email,
+        )
+
+        get_resp = self.client.get(self.user_profile_url, format='json')
+        self.assertEqual(
+            get_resp.status_code,
+            rest_framework.status.HTTP_200_OK,
+        )
+        self.assertEqual(
+            get_resp.data.get('email'),
+            new_email,
+        )
diff --git a/promo_code/user/tests/user/test_antifraud_service.py b/promo_code/user/tests/user/test_antifraud_service.py
@@ -129,3 +129,11 @@ def test_handles_api_http_error(self, mock_cache, mock_post):
             result,
             {'ok': False, 'error': 'Anti-fraud service unavailable'},
         )
+
+    def test_calculate_cache_timeout_none_when_missing(self):
+        self.assertIsNone(
+            self.service._calculate_cache_timeout(None),
+        )
+        self.assertIsNone(
+            self.service._calculate_cache_timeout(''),
+        )
diff --git a/promo_code/user/tests/user/test_models.py b/promo_code/user/tests/user/test_models.py
@@ -0,0 +1,91 @@
+import django.test
+import django.utils.timezone
+
+import business.models
+import user.models
+
+
+class UserManagerTests(django.test.TestCase):
+    def test_create_user_without_email_raises_error(self):
+        with self.assertRaises(ValueError):
+            user.models.User.objects.create_user(
+                email=None,
+                name='Test',
+                surname='User',
+            )
+
+    def test_create_superuser(self):
+        user_ = user.models.User.objects.create_superuser(
+            email='super@test.com',
+            name='Super',
+            surname='User',
+            password='password123',
+        )
+        self.assertTrue(user_.is_staff)
+        self.assertTrue(user_.is_superuser)
+        self.assertEqual(user_.email, 'super@test.com')
+
+
+class UserModelTests(django.test.TestCase):
+    def setUp(self):
+        self.user_ = user.models.User.objects.create_user(
+            email='test@example.com',
+            name='Test',
+            surname='User',
+            password='password123',
+        )
+
+    def test_user_str_representation(self):
+        self.assertEqual(str(self.user_), 'test@example.com')
+
+
+class RelatedModelsStrTests(django.test.TestCase):
+    def setUp(self):
+        self.user_ = user.models.User.objects.create(
+            email='user@test.com',
+            name='Test',
+            surname='User',
+        )
+        self.company = business.models.Company.objects.create(
+            email='company@test.com',
+            name='TestCorp',
+        )
+        self.promo = business.models.Promo.objects.create(
+            company=self.company,
+            description='Test Promo',
+            max_count=100,
+            mode='COMMON',
+        )
+
+    def test_promo_like_str(self):
+        like = user.models.PromoLike.objects.create(
+            user=self.user_,
+            promo=self.promo,
+        )
+        expected_str = f'{self.user_} likes {self.promo}'
+        self.assertEqual(str(like), expected_str)
+
+    def test_promo_comment_str(self):
+        comment = user.models.PromoComment.objects.create(
+            author=self.user_,
+            promo=self.promo,
+            text='A test comment.',
+        )
+        expected_str = (
+            f'Comment by {self.user_.email} on promo {self.promo.id}'
+        )
+        self.assertEqual(str(comment), expected_str)
+
+    def test_promo_activation_history_str(self):
+        activation = user.models.PromoActivationHistory.objects.create(
+            user=self.user_,
+            promo=self.promo,
+        )
+        activation.activated_at = django.utils.timezone.now()
+        activation.save()
+
+        expected_str = (
+            f'{self.user_} activated {self.promo.id} at '
+            f'{activation.activated_at}'
+        )
+        self.assertEqual(str(activation), expected_str)
diff --git a/promo_code/user/tests/user/test_services.py b/promo_code/user/tests/user/test_services.py
@@ -0,0 +1,99 @@
+import unittest.mock
+
+import django.test
+
+import business.constants
+import business.models
+import user.models
+import user.services
+
+
+@unittest.mock.patch(
+    'user.antifraud_service.antifraud_service.get_verdict',
+    return_value={'ok': True},
+)
+class PromoActivationServiceTestCase(django.test.TestCase):
+    def setUp(self):
+        self.user_ = user.models.User.objects.create_user(
+            name='John',
+            surname='Jones',
+            email='test@example.com',
+            password='password123',
+            other={'country': 'lu', 'age': 30},
+        )
+        self.promo = business.models.Promo.objects.create(
+            description='Test Promo',
+            active=True,
+            target={'country': 'lu', 'age_from': 20, 'age_until': 40},
+            mode=business.constants.PROMO_MODE_COMMON,
+            max_count=100,
+            used_count=0,
+            promo_common='COMMON_CODE',
+        )
+
+    def test_targeting_fails_if_age_from_and_user_age_is_none(
+        self,
+        mock_antifraud,
+    ):
+        self.user_.other = {'country': 'lu', 'age': 30}
+        self.user_.save()
+        self.promo.target = {'age_until': 25}
+        self.promo.save()
+
+        service = user.services.PromoActivationService(
+            user=self.user_,
+            promo=self.promo,
+        )
+
+        with self.assertRaisesRegex(
+            user.services.TargetingError,
+            'Age mismatch.',
+        ):
+            service.activate()
+
+    def test_targeting_fails_if_age_until_mismatch(self, mock_antifraud):
+        self.promo.target = {'age_until': 25}
+        self.promo.save()
+
+        service = user.services.PromoActivationService(
+            user=self.user_,
+            promo=self.promo,
+        )
+
+        with self.assertRaisesRegex(
+            user.services.TargetingError,
+            'Age mismatch.',
+        ):
+            service.activate()
+
+    def test_targeting_fails_if_age_from_mismatch(self, mock_antifraud):
+        self.promo.target = {'age_from': 31}
+        self.promo.save()
+
+        service = user.services.PromoActivationService(
+            user=self.user_,
+            promo=self.promo,
+        )
+
+        with self.assertRaisesRegex(
+            user.services.TargetingError,
+            'Age mismatch.',
+        ):
+            service.activate()
+
+    def test_activation_fails_if_promo_deleted_mid_process(
+        self,
+        mock_antifraud,
+    ):
+        service = user.services.PromoActivationService(
+            user=self.user_,
+            promo=self.promo,
+        )
+
+        self.promo.delete()
+
+        with self.assertRaisesRegex(
+            user.services.PromoActivationError,
+            'Promo not found.',
+        ):
+            service.activate()
diff --git a/promo_code/user/tests/user/validations/test_profile_validation.py b/promo_code/user/tests/user/validations/test_profile_validation.py
