Skip to content

Commit bbeb836

Browse files
authored
fix: Adjust scroll from clipping children form fields in AlertDialog from showSourcesDialog (#1782)
1 parent a99406f commit bbeb836

File tree

1 file changed

+60
-61
lines changed

1 file changed

+60
-61
lines changed

lib/ui/views/settings/settingsFragment/settings_manage_sources.dart

Lines changed: 60 additions & 61 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ class SManageSources extends BaseViewModel {
2727
return showDialog(
2828
context: context,
2929
builder: (context) => AlertDialog(
30+
scrollable: true,
3031
title: Row(
3132
children: <Widget>[
3233
Expanded(
@@ -39,75 +40,73 @@ class SManageSources extends BaseViewModel {
3940
),
4041
],
4142
),
42-
content: SingleChildScrollView(
43-
child: Column(
44-
children: <Widget>[
45-
TextField(
46-
controller: _orgPatSourceController,
47-
autocorrect: false,
48-
onChanged: (value) => notifyListeners(),
49-
decoration: InputDecoration(
50-
icon: Icon(
51-
Icons.extension_outlined,
52-
color: Theme.of(context).colorScheme.onSurfaceVariant,
53-
),
54-
border: const OutlineInputBorder(),
55-
labelText: t.settingsView.orgPatchesLabel,
56-
hintText: patchesRepo.split('/')[0],
43+
content: Column(
44+
children: <Widget>[
45+
TextField(
46+
controller: _orgPatSourceController,
47+
autocorrect: false,
48+
onChanged: (value) => notifyListeners(),
49+
decoration: InputDecoration(
50+
icon: Icon(
51+
Icons.extension_outlined,
52+
color: Theme.of(context).colorScheme.onSurfaceVariant,
5753
),
54+
border: const OutlineInputBorder(),
55+
labelText: t.settingsView.orgPatchesLabel,
56+
hintText: patchesRepo.split('/')[0],
5857
),
59-
const SizedBox(height: 8),
60-
// Patches repository's name
61-
TextField(
62-
controller: _patSourceController,
63-
autocorrect: false,
64-
onChanged: (value) => notifyListeners(),
65-
decoration: InputDecoration(
66-
icon: const Icon(
67-
Icons.extension_outlined,
68-
color: Colors.transparent,
69-
),
70-
border: const OutlineInputBorder(),
71-
labelText: t.settingsView.sourcesPatchesLabel,
72-
hintText: patchesRepo.split('/')[1],
58+
),
59+
const SizedBox(height: 8),
60+
// Patches repository's name
61+
TextField(
62+
controller: _patSourceController,
63+
autocorrect: false,
64+
onChanged: (value) => notifyListeners(),
65+
decoration: InputDecoration(
66+
icon: const Icon(
67+
Icons.extension_outlined,
68+
color: Colors.transparent,
7369
),
70+
border: const OutlineInputBorder(),
71+
labelText: t.settingsView.sourcesPatchesLabel,
72+
hintText: patchesRepo.split('/')[1],
7473
),
75-
const SizedBox(height: 8),
76-
// Integrations owner's name
77-
TextField(
78-
controller: _orgIntSourceController,
79-
autocorrect: false,
80-
onChanged: (value) => notifyListeners(),
81-
decoration: InputDecoration(
82-
icon: Icon(
83-
Icons.merge_outlined,
84-
color: Theme.of(context).colorScheme.onSurfaceVariant,
85-
),
86-
border: const OutlineInputBorder(),
87-
labelText: t.settingsView.orgIntegrationsLabel,
88-
hintText: integrationsRepo.split('/')[0],
74+
),
75+
const SizedBox(height: 8),
76+
// Integrations owner's name
77+
TextField(
78+
controller: _orgIntSourceController,
79+
autocorrect: false,
80+
onChanged: (value) => notifyListeners(),
81+
decoration: InputDecoration(
82+
icon: Icon(
83+
Icons.merge_outlined,
84+
color: Theme.of(context).colorScheme.onSurfaceVariant,
8985
),
86+
border: const OutlineInputBorder(),
87+
labelText: t.settingsView.orgIntegrationsLabel,
88+
hintText: integrationsRepo.split('/')[0],
9089
),
91-
const SizedBox(height: 8),
92-
// Integrations repository's name
93-
TextField(
94-
controller: _intSourceController,
95-
autocorrect: false,
96-
onChanged: (value) => notifyListeners(),
97-
decoration: InputDecoration(
98-
icon: const Icon(
99-
Icons.merge_outlined,
100-
color: Colors.transparent,
101-
),
102-
border: const OutlineInputBorder(),
103-
labelText: t.settingsView.sourcesIntegrationsLabel,
104-
hintText: integrationsRepo.split('/')[1],
90+
),
91+
const SizedBox(height: 8),
92+
// Integrations repository's name
93+
TextField(
94+
controller: _intSourceController,
95+
autocorrect: false,
96+
onChanged: (value) => notifyListeners(),
97+
decoration: InputDecoration(
98+
icon: const Icon(
99+
Icons.merge_outlined,
100+
color: Colors.transparent,
105101
),
102+
border: const OutlineInputBorder(),
103+
labelText: t.settingsView.sourcesIntegrationsLabel,
104+
hintText: integrationsRepo.split('/')[1],
106105
),
107-
const SizedBox(height: 20),
108-
Text(t.settingsView.sourcesUpdateNote),
109-
],
110-
),
106+
),
107+
const SizedBox(height: 20),
108+
Text(t.settingsView.sourcesUpdateNote),
109+
],
111110
),
112111
actions: <Widget>[
113112
TextButton(

0 commit comments

Comments
 (0)