fix list summary updating after refactor

Author: MarcaDian

extensions/shared/library/src/main/java/app/revanced/extension/shared/settings/preference/CustomDialogListPreference.java

@@ -12,6 +12,7 @@
 import android.widget.*;
 
 import androidx.annotation.NonNull;
+import androidx.annotation.Nullable;
 
 import app.revanced.extension.shared.Utils;
 import app.revanced.extension.shared.ui.CustomDialog;
@@ -43,6 +44,14 @@ public void setStaticSummary(String summary) {
         this.staticSummary = summary;
     }
 
+    /**
+     * Returns the static summary if set, otherwise null.
+     */
+    @Nullable
+    public String getStaticSummary() {
+        return staticSummary;
+    }
+
     /**
      * Always return static summary if set.
      */

extensions/youtube/src/main/java/app/revanced/extension/youtube/settings/search/SearchResultItem.java

@@ -239,6 +239,18 @@ public CharSequence getCurrentEffectiveSummary() {
                         originalSummary != null ? originalSummary : "")
                         : (originalSummaryOff != null ? originalSummaryOff :
                         originalSummary != null ? originalSummary : "");
+            } else if (preference instanceof ListPreference listPref) {
+                String value = listPref.getValue();
+                CharSequence[] entries = listPref.getEntries();
+                CharSequence[] entryValues = listPref.getEntryValues();
+                if (value != null && entries != null && entryValues != null) {
+                    for (int i = 0; i < entryValues.length; i++) {
+                        if (value.equals(entryValues[i].toString())) {
+                            return entries[i] != null ? entries[i] : originalSummary != null ? originalSummary : "";
+                        }
+                    }
+                }
+                return originalSummary != null ? originalSummary : "";
             }
             return originalSummary != null ? originalSummary : "";
         }

extensions/youtube/src/main/java/app/revanced/extension/youtube/settings/search/SearchResultsAdapter.java

@@ -7,10 +7,7 @@
 import android.content.Context;
 import android.os.Handler;
 import android.os.Looper;
-import android.preference.Preference;
-import android.preference.PreferenceGroup;
-import android.preference.PreferenceScreen;
-import android.preference.SwitchPreference;
+import android.preference.*;
 import android.text.TextUtils;
 import android.view.LayoutInflater;
 import android.view.View;
@@ -177,11 +174,20 @@ private View createPreferenceView(SearchResultItem item, View convertView,
             case REGULAR, URL_LINK, LIST -> {
                 RegularViewHolder regularHolder = (RegularViewHolder) holder;
                 SearchResultItem.PreferenceSearchItem prefItem = (SearchResultItem.PreferenceSearchItem) item;
+                prefItem.refreshHighlighting();
                 regularHolder.titleView.setText(item.highlightedTitle);
                 regularHolder.summaryView.setText(item.highlightedSummary);
                 regularHolder.summaryView.setVisibility(TextUtils.isEmpty(item.highlightedSummary) ? View.GONE : View.VISIBLE);
                 setupPreferenceView(view, regularHolder.titleView, regularHolder.summaryView, prefItem.preference,
-                        () -> handlePreferenceClick(prefItem.preference),
+                        () -> {
+                            handlePreferenceClick(prefItem.preference);
+                            if (prefItem.preference instanceof ListPreference) {
+                                prefItem.refreshHighlighting();
+                                regularHolder.summaryView.setText(prefItem.getCurrentEffectiveSummary());
+                                regularHolder.summaryView.setVisibility(TextUtils.isEmpty(prefItem.highlightedSummary) ? View.GONE : View.VISIBLE);
+                                notifyDataSetChanged();
+                            }
+                        },
                         () -> navigateAndScrollToPreference(item));
             }
             case SWITCH -> {

extensions/youtube/src/main/java/app/revanced/extension/youtube/settings/search/SearchViewController.java

@@ -6,10 +6,7 @@
 import android.app.Activity;
 import android.content.Context;
 import android.graphics.drawable.GradientDrawable;
-import android.preference.Preference;
-import android.preference.PreferenceCategory;
-import android.preference.PreferenceGroup;
-import android.preference.PreferenceScreen;
+import android.preference.*;
 import android.text.TextUtils;
 import android.view.*;
 import android.view.inputmethod.EditorInfo;
@@ -27,6 +24,7 @@
 import app.revanced.extension.shared.settings.BaseSettings;
 import app.revanced.extension.shared.settings.Setting;
 import app.revanced.extension.shared.settings.preference.ColorPickerPreference;
+import app.revanced.extension.shared.settings.preference.CustomDialogListPreference;
 import app.revanced.extension.shared.settings.preference.NoTitlePreferenceCategory;
 import app.revanced.extension.youtube.settings.LicenseActivityHook;
 import app.revanced.extension.youtube.sponsorblock.objects.SegmentCategoryListPreference;
@@ -331,6 +329,28 @@ private void setupPreferenceListeners() {
                     }
                     return true;
                 });
+            } else if (pref instanceof CustomDialogListPreference listPref) {
+                listPref.setOnPreferenceChangeListener((preference, newValue) -> {
+                    SearchResultItem.PreferenceSearchItem searchItem =
+                            (SearchResultItem.PreferenceSearchItem) keyToSearchItem.get(preference.getKey());
+                    if (searchItem == null) return true;
+
+                    int index = listPref.findIndexOfValue(newValue.toString());
+                    if (index >= 0) {
+                        // Check if a static summary is set.
+                        boolean isStaticSummary = listPref.getStaticSummary() != null;
+
+                        if (!isStaticSummary) {
+                            // Only update summary if it is not static.
+                            CharSequence newSummary = listPref.getEntries()[index];
+                            searchItem.refreshHighlighting();
+                            listPref.setSummary(newSummary);
+                        }
+                    }
+
+                    refreshSearchResults();
+                    return true;
+                });
             }
         }
     }
@@ -448,6 +468,9 @@ private void filterAndShowResults(String query) {
                         SearchResultItem parentItem = keyToSearchItem.get(parentSetting.key);
                         if (parentItem != null && !addedParentKeys.contains(parentSetting.key)) {
                             if (!parentItem.matchesQuery(queryLower)) {
+                                // Apply highlighting to parent items even if they don't match the query.
+                                // This ensures they get their current effective summary calculated.
+                                parentItem.applyHighlighting(queryPattern);
                                 filteredSearchItems.add(parentItem);
                             }
                             addedParentKeys.add(parentSetting.key);