Skip to content

fix(Spoof app signature): Resolve errors when patching without CLI tools #5353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
+2 −2
Open

fix(Spoof app signature): Resolve errors when patching without CLI tools #5353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion patches/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ dependencies {
// Required due to smali, or build fails. Can be removed once smali is bumped.
implementation(libs.guava)

implementation(libs.apksig)
"shade"(libs.apksig)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this an API from the Gradle plugin? I haven't checked yet

Copy link
Contributor Author

@MarkusTieger MarkusTieger Jul 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well yes, I added the "shade" configuration in the gradle plugin pr.

Shadow uses the runtimeClasspath by default, but currently there is the revanced-patcher, guava and smali inside the runtimeClasspath (via implementation), and we don't want that to be shaded in. So I added the "shade" configuration.

See https://github.com/ReVanced/revanced-patches-gradle-plugin/blob/ea5affec560f504491f106de01e1a15edcf7c3ac/src/main/kotlin/app/revanced/patches/gradle/PatchesPlugin.kt#L266-L268


// Android API stubs defined here.
compileOnly(project(":patches:stub"))
Expand Down
2 changes: 1 addition & 1 deletion settings.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ pluginManagement {
}

plugins {
id("app.revanced.patches") version "1.0.0-dev.7"
id("app.revanced.patches") version "1.0.0-dev.9"
}

settings {
Expand Down
Loading