Skip to content

Conversation

@alexandre-abrioux-rf
Copy link
Contributor

@alexandre-abrioux-rf alexandre-abrioux-rf commented Nov 5, 2025

Description of the changes

This fixes an issue with hardhat not being able to download the Solidity Compiler in more recent Node.js versions.

Summary by CodeRabbit

  • Chores
    • Updated development tooling to the latest compatible versions for improved stability and security.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 5, 2025

Walkthrough

Updated the hardhat dependency in the smart-contracts package from version 2.22.15 to 2.26.5. This is a minor version upgrade that introduces new features and bug fixes.

Changes

Cohort / File(s) Summary
Dependency Update
packages/smart-contracts/package.json
Upgraded hardhat from 2.22.15 to 2.26.5

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify hardhat 2.26.5 compatibility with existing smart contract code
  • Check changelog between 2.22.15 and 2.26.5 for breaking changes
  • Confirm package-lock.json or yarn.lock is properly updated with transitive dependencies

Suggested reviewers

  • rodrigopavezi
  • kevindavee
  • yomarion
  • aimensahnoun

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: bump hardhat' directly matches the main change—updating the hardhat dependency from 2.22.15 to 2.26.5.
Description check ✅ Passed The description includes the required 'Description of the changes' section with a clear explanation linking the hardhat bump to resolving a specific issue with Solidity Compiler downloads.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bump-hardhat

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d6aabfa and 639761e.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • packages/smart-contracts/package.json (1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: giorgi-kiknavelidze
Repo: RequestNetwork/requestNetwork PR: 1482
File: packages/usage-examples/package.json:42-42
Timestamp: 2024-11-04T12:18:18.615Z
Learning: In the RequestNetwork project, the `dotenv` package version is maintained at `10.0.0` across packages, including `packages/smart-contracts/package.json`, to ensure consistency.
📚 Learning: 2024-11-04T12:18:18.615Z
Learnt from: giorgi-kiknavelidze
Repo: RequestNetwork/requestNetwork PR: 1482
File: packages/usage-examples/package.json:42-42
Timestamp: 2024-11-04T12:18:18.615Z
Learning: In the RequestNetwork project, the `dotenv` package version is maintained at `10.0.0` across packages, including `packages/smart-contracts/package.json`, to ensure consistency.

Applied to files:

  • packages/smart-contracts/package.json
📚 Learning: 2024-11-18T12:33:47.986Z
Learnt from: rodrigopavezi
Repo: RequestNetwork/requestNetwork PR: 1475
File: packages/epk-cypher/package.json:49-67
Timestamp: 2024-11-18T12:33:47.986Z
Learning: In the `packages/epk-cypher/package.json` file, avoid suggesting updates to development dependencies unless essential, as the maintainer prefers to prevent potential instability.

Applied to files:

  • packages/smart-contracts/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build-and-test
🔇 Additional comments (1)
packages/smart-contracts/package.json (1)

85-85: Verify hardhat plugin compatibility with 2.26.5.

The hardhat version bump to 2.26.5 should address the solc download issue on newer Node.js versions. However, ensure that the hardhat ecosystem plugins listed in this file remain compatible with the new version.

Please verify:

  1. All hardhat-related plugins (particularly the @matterlabs/hardhat-zksync suite at lines 58–61 and @typechain/hardhat at line 76) are compatible with hardhat 2.26.5.
  2. The test suite passes (yarn test) with the updated hardhat version.
  3. That the solc download issue is resolved with this update by testing compilation on the CI environment with Node.js ≥ 22.0.0.

You can check for any known incompatibilities or breaking changes between hardhat 2.22.15 and 2.26.5 in the hardhat changelog.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member

@MantisClone MantisClone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

FYI @rodrigopavezi Does this impact your work on #1649?

@alexandre-abrioux-rf alexandre-abrioux-rf enabled auto-merge (squash) November 7, 2025 08:28
@alexandre-abrioux-rf alexandre-abrioux-rf merged commit 32d0d88 into master Nov 7, 2025
10 checks passed
@alexandre-abrioux-rf alexandre-abrioux-rf deleted the bump-hardhat branch November 7, 2025 08:42
@alexandre-abrioux-rf
Copy link
Contributor Author

@MantisClone @rodrigopavezi I've merged because it's a minor bump, so I assume it will work, but feel free to revert in case it doesn't 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants