Skip to content

Commit 9df70d6

Browse files
author
atsakiridis
committed
Fixed #251: Hangup button can be pressed even outside the button boundaries
1 parent 1e11a51 commit 9df70d6

File tree

2 files changed

+3
-9
lines changed
  • Examples/restcomm-olympus/app/src/main/res/layout
  • restcomm.android.client.sdk/src/main/java/org/mobicents/restcomm/android/sipua/impl

2 files changed

+3
-9
lines changed

Examples/restcomm-olympus/app/src/main/res/layout/activity_call.xml

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -54,15 +54,12 @@
5454
<ImageButton
5555
android:layout_width="wrap_content"
5656
android:layout_height="wrap_content"
57-
android:id="@+id/button_hangup"
5857
android:background="@android:color/transparent"
5958
android:src="@drawable/hangup_74x74"
59+
android:id="@+id/button_hangup"
6060
android:layout_marginBottom="20dp"
6161
android:layout_alignParentBottom="true"
62-
android:layout_alignParentLeft="true"
63-
android:layout_alignParentStart="true"
64-
android:layout_alignParentRight="true"
65-
android:layout_alignParentEnd="true" />
62+
android:layout_centerHorizontal="true" />
6663

6764
<ImageButton
6865
android:layout_width="wrap_content"
@@ -128,8 +125,6 @@
128125
android:layout_marginStart="58dp"
129126
android:layout_marginBottom="10dp"/>
130127

131-
132-
133128
<!-- placeholder for keypad fragment -->
134129
<FrameLayout
135130
android:id="@+id/keypad_fragment_container"

restcomm.android.client.sdk/src/main/java/org/mobicents/restcomm/android/sipua/impl/SipManager.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -775,9 +775,8 @@ public void processResponse(ResponseEvent arg0) {
775775
.getAuthenticationHelper(
776776
new AccountManagerImpl(sipProfile.getSipUserName(),
777777
responseEvent.getRemoteIpAddress(), sipProfile
778-
//sipProfile.getRemoteIp(addressFactory), sipProfile
779778
.getSipPassword()), headerFactory);
780-
CallIdHeader callId = (CallIdHeader)response.getHeader("Call-ID"); //responseDialog.getCallId();
779+
CallIdHeader callId = (CallIdHeader)response.getHeader("Call-ID");
781780
int attempts = 0;
782781
if (registerAuthenticationMap.containsKey(callId.toString())) {
783782
attempts = registerAuthenticationMap.get(callId.toString()).intValue();

0 commit comments

Comments
 (0)