-
Notifications
You must be signed in to change notification settings - Fork 2
24 implement file reader to read files chunk by chunk #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dasunpubudumal
wants to merge
30
commits into
main
Choose a base branch
from
24-implement-file-reader-to-read-files-chunk-by-chunk
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
24 implement file reader to read files chunk by chunk #25
dasunpubudumal
wants to merge
30
commits into
main
from
24-implement-file-reader-to-read-files-chunk-by-chunk
+1,694
−1,283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24
Changes proposed in this pull request:
The file structure has been updated to match Rust's Modularity Guidelines. This includes 1) splitting business logic functions into a library crate, and 2) using the entrypoint of the binary crate (
main.rs) only to call therun()function in library crate.clap's enum-based command parsingThis is a popular pattern to parse command-line arguments used in open-source projects such as Zed.
The responsibility of handling each type of command were delegated to the processors listed in
src/processorsdirectory. The main reference for modularising the code was the official guide.itertoolslibrary'schunkfunction to create a file readerA file reader has been created to read a file chunk-by-chunk. A chunk is defined by a number of lines of a file; for example, if
chunkis given to be 10,read_file_by_batchofBatchFileReaderwill apply functionfto each chunk of 10 lines.As per official Rust Guideline on Tests, unit tests for the file reader were written where the logic is.